This repository was archived by the owner on Jun 6, 2025. It is now read-only.
gh-149: Replace usage of Math.floorMod() with % operator. #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #231 +/- ##
=============================================
+ Coverage 81.13% 81.14% +0.01%
- Complexity 1534 1538 +4
=============================================
Files 185 185
Lines 4268 4281 +13
Branches 430 431 +1
=============================================
+ Hits 3463 3474 +11
- Misses 627 629 +2
Partials 178 178
Continue to review full report at Codecov.
|
t92549
approved these changes
Nov 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve performance and readability by swapping the Math.floorMod() method for the % operator.
The only difference between the two should be when there are negative inputs, but that doesn't apply here as we'd always expect valid input to this function (i.e. the timestamp should also be positive).
Related Issue