Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jun 6, 2025. It is now read-only.

Conversation

@cn337131
Copy link
Member

@cn337131 cn337131 commented Jan 15, 2025

  • Adds a varargs constructor to ChainedIterator.java
  • Add a new IterableMerge binary operator that concats iterables (similar to the IterableConcat function)

Related issue

@cn337131 cn337131 marked this pull request as ready for review January 15, 2025 12:42

package uk.gov.gchq.koryphe.iterable;

import org.apache.commons.lang3.ArrayUtils;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend against this unless there's no other easy way to do this with external libraries.

@sonarqubecloud
Copy link

@cn337131 cn337131 added the enhancement Improvement to existing functionality/feature label Jan 23, 2025
@j69772 j69772 merged commit f2dead6 into develop Jan 27, 2025
4 checks passed
@j69772 j69772 deleted the gh-321-chained-iterator-varargs-constructor branch January 27, 2025 10:47
@cn337131 cn337131 added this to the 2.6.0 milestone Jan 28, 2025
j69772 added a commit that referenced this pull request Jan 29, 2025
* prepare for next development iteration

* Gh-310: Improve JUnit tests to run in parallel (#311)

* Enable parallelism at class level with thread count equal to CPU threads
Also fix config to apply always (not just profile) and remove outdated 'junit-platform-surefire-provider' dependency

* Update versions for JUnit, AssertJ etc.

* Fix Maven default platform encoding warning message

* Gh-313: Upgrade json from 20211205 to 20230227 (#312)

Bumps [json](https://github.com/douglascrockford/JSON-java) from 20211205 to 20230227.
- [Release notes](https://github.com/douglascrockford/JSON-java/releases)
- [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md)
- [Commits](https://github.com/douglascrockford/JSON-java/commits)

---
updated-dependencies:
- dependency-name: org.json:json
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update codecov (#315)

* Gh 307: Upgrade workflows (#318)

* Upgrade GitHub workflows

* Version fix

* Update .github/workflows/release.yaml

Co-authored-by: GCHQDeveloper314 <[email protected]>

* Remove unsupported actions and fix git config

---------

Co-authored-by: GCHQDeveloper314 <[email protected]>

* Gh-324: Make IterableConcat's type signature more flexible (#325)

* Make IterableConcat type signature more flexible
IterableConcat can now easily accept nested Iterables which extend Iterable in more cases

* Fix example

* Update copyright

* Fix Quality Gate

* Gh-236: Update GH actions (#327)

fix versions, update release process and remove gh action

* Gh-321: Add ChainedIterator varargs constructor and IterableMerge binary operator (#328)

* add new iterable merge binary operator and varargs to chainedItr

* checkstyle

* address comments

* checkstyle

* Bump commons-io:commons-io from 2.11.0 to 2.14.0 (#323)

* Bump commons-io:commons-io from 2.11.0 to 2.14.0

Bumps commons-io:commons-io from 2.11.0 to 2.14.0.

---
updated-dependencies:
- dependency-name: commons-io:commons-io
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update copyright for pom.xml

* copyright

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: GCHQDeveloper314 <[email protected]>
Co-authored-by: j69772 <[email protected]>
Co-authored-by: cn337131 <[email protected]>

* Gh-320: Javadoc fixes (#329)

* fix javadocs

* rephrase

* copyright

---------

Co-authored-by: j69772 <[email protected]>

* Bump org.json:json from 20230227 to 20231013 (#330)

Bumps [org.json:json](https://github.com/douglascrockford/JSON-java) from 20230227 to 20231013.
- [Release notes](https://github.com/douglascrockford/JSON-java/releases)
- [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md)
- [Commits](https://github.com/douglascrockford/JSON-java/commits)

---
updated-dependencies:
- dependency-name: org.json:json
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: j69772 <[email protected]>

* prepare release koryphe-2.6.0

* copyright

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Gaffer <[email protected]>
Co-authored-by: GCHQDeveloper314 <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: cn337131 <[email protected]>
Co-authored-by: j69772 <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement Improvement to existing functionality/feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ChainedIterator doesn't have a varargs constructor

6 participants