Fix decision coverage for excluded lines #617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ba0b55 to
5575638
Compare
Codecov Report
@@ Coverage Diff @@
## master #617 +/- ##
==========================================
- Coverage 95.11% 95.08% -0.03%
==========================================
Files 24 24
Lines 3357 3359 +2
Branches 630 631 +1
==========================================
+ Hits 3193 3194 +1
Misses 93 93
- Partials 71 72 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
5575638 to
724b792
Compare
latk
approved these changes
Aug 4, 2022
gcovr/merging.py
Outdated
Comment on lines
193
to
197
| def get_line_coverage(target: FileCoverage, lineno: int) -> LineCoverage: | ||
| """Get the LineCoverage object for that line if available.""" | ||
| if lineno in target.lines: | ||
| return target.lines[lineno] | ||
| return None |
There was a problem hiding this comment.
Instead of creating this function, I'd consider target.lines.get(lineno).
e75786d to
3b7cf55
Compare
D-Walther
pushed a commit
to D-Walther/gcovr
that referenced
this pull request
Jun 16, 2025
* Do not add coverage for excluded lines in decision analysis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not add lines to coverage data by decision analysis.