Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Spacetown
Copy link
Member

This PR replaces the copy command used for updating the reference data and create the reference file with the scrubbed data.

@Spacetown Spacetown added QA related to testing, build infrastructure, etc Internal change Internal change not visible to user labels Dec 5, 2022
@Spacetown Spacetown added this to the Upcoming release milestone Dec 5, 2022
@Spacetown Spacetown force-pushed the use_scrubbed_data_for_update_of_reference branch from 0d8cb92 to 0d31a11 Compare December 5, 2022 21:40
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 95.49% // Head: 95.48% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (34f8ce2) compared to base (ad1657d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #698      +/-   ##
==========================================
- Coverage   95.49%   95.48%   -0.01%     
==========================================
  Files          27       27              
  Lines        3506     3500       -6     
  Branches      605      605              
==========================================
- Hits         3348     3342       -6     
  Misses         90       90              
  Partials       68       68              
Flag Coverage Δ
ubuntu-20.04 94.39% <100.00%> (-0.01%) ⬇️
windows-2019 95.16% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gcovr/tests/test_gcovr.py 97.64% <100.00%> (-0.09%) ⬇️
gcovr/writer/csv.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@latk latk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, as far as I can tell!

Open file for csv.write with newline="" as mentioned in the docs.
Without this "\n" is translated on Windows to "\r\n" which results in "\r\r\n". See also footnote in python docs: https://docs.python.org/3.10/library/csv.html?highlight=csv%20writer#id3
@Spacetown Spacetown marked this pull request as ready for review December 6, 2022 18:24
@Spacetown Spacetown merged commit 451b176 into gcovr:master Dec 6, 2022
@Spacetown Spacetown deleted the use_scrubbed_data_for_update_of_reference branch December 6, 2022 18:27
D-Walther pushed a commit to D-Walther/gcovr that referenced this pull request Jun 16, 2025
* Remove normalization of newlines because this is already done by the open.
* Allocate a pseudo-TTY for Docker to get colored output.
* Force color output in CI.
* Fix line endings for CSV on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Internal change Internal change not visible to user QA related to testing, build infrastructure, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants