-
Notifications
You must be signed in to change notification settings - Fork 288
Use scrubbed data for update of reference #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use scrubbed data for update of reference #698
Conversation
0d8cb92 to
0d31a11
Compare
Codecov ReportBase: 95.49% // Head: 95.48% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #698 +/- ##
==========================================
- Coverage 95.49% 95.48% -0.01%
==========================================
Files 27 27
Lines 3506 3500 -6
Branches 605 605
==========================================
- Hits 3348 3342 -6
Misses 90 90
Partials 68 68
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, as far as I can tell!
Open file for csv.write with newline="" as mentioned in the docs. Without this "\n" is translated on Windows to "\r\n" which results in "\r\r\n". See also footnote in python docs: https://docs.python.org/3.10/library/csv.html?highlight=csv%20writer#id3
* Remove normalization of newlines because this is already done by the open. * Allocate a pseudo-TTY for Docker to get colored output. * Force color output in CI. * Fix line endings for CSV on Windows
This PR replaces the copy command used for updating the reference data and create the reference file with the scrubbed data.