Reworke noncode exclusion #705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 95.55% // Head: 95.55% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #705 +/- ##
=======================================
Coverage 95.55% 95.55%
=======================================
Files 28 28
Lines 3736 3736
Branches 640 640
=======================================
Hits 3570 3570
Misses 93 93
Partials 73 73
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
kodiakhq bot
pushed a commit
to acts-project/acts
that referenced
this pull request
Nov 5, 2023
Addresses and closes Issue #1211 ---------------------------------- The supposed problem was "Parallel processing of gcov data. ([#%s592](gcovr/gcovr#592))" in gcov 5.1. This was already fixed in 5.2. We need to add `--exclude-noncode-lines` due to a breaking change in gcovr 6.0, otherwise our coverage would change a lot (-0.33%): New [--exclude-noncode-lines](https://gcovr.com/en/stable/manpage.html#cmdoption-gcovr-exclude-noncode-lines) to exclude noncode lines. Noncode lines are not excluded by default anymore. ([#%s704](gcovr/gcovr#704), [#%s705](gcovr/gcovr#705)) Closes #1211 Update the gcovr-call ---------------------- - remove use of local bundled version (files were removed some years ago) - remove outdated exclude of folder `/Legacy/` - remind user to update gcovr to at least `v5.0` - assert if `v5.1` is used - black
njacazio
pushed a commit
to njacazio/acts
that referenced
this pull request
Jun 13, 2025
…ect#2629) Addresses and closes Issue acts-project#1211 ---------------------------------- The supposed problem was "Parallel processing of gcov data. ([#%s592](gcovr/gcovr#592))" in gcov 5.1. This was already fixed in 5.2. We need to add `--exclude-noncode-lines` due to a breaking change in gcovr 6.0, otherwise our coverage would change a lot (-0.33%): New [--exclude-noncode-lines](https://gcovr.com/en/stable/manpage.html#cmdoption-gcovr-exclude-noncode-lines) to exclude noncode lines. Noncode lines are not excluded by default anymore. ([#%s704](gcovr/gcovr#704), [#%s705](gcovr/gcovr#705)) Closes acts-project#1211 Update the gcovr-call ---------------------- - remove use of local bundled version (files were removed some years ago) - remove outdated exclude of folder `/Legacy/` - remind user to update gcovr to at least `v5.0` - assert if `v5.1` is used - black
njacazio
pushed a commit
to njacazio/acts
that referenced
this pull request
Jun 13, 2025
…ect#2629) Addresses and closes Issue acts-project#1211 ---------------------------------- The supposed problem was "Parallel processing of gcov data. ([#%s592](gcovr/gcovr#592))" in gcov 5.1. This was already fixed in 5.2. We need to add `--exclude-noncode-lines` due to a breaking change in gcovr 6.0, otherwise our coverage would change a lot (-0.33%): New [--exclude-noncode-lines](https://gcovr.com/en/stable/manpage.html#cmdoption-gcovr-exclude-noncode-lines) to exclude noncode lines. Noncode lines are not excluded by default anymore. ([#%s704](gcovr/gcovr#704), [#%s705](gcovr/gcovr#705)) Closes acts-project#1211 Update the gcovr-call ---------------------- - remove use of local bundled version (files were removed some years ago) - remove outdated exclude of folder `/Legacy/` - remind user to update gcovr to at least `v5.0` - assert if `v5.1` is used - black
D-Walther
pushed a commit
to D-Walther/gcovr
that referenced
this pull request
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change option as suggested in #704.
gcc-11,clang-10andclang-11put branches on closing braces which where excluded bygcovr. Now the default is to not exclude this lines and use the unfiltered data from gcov. With the option--exclude-noncode-linesthe user can activate the previous behavior.Related issue: #212