-
Notifications
You must be signed in to change notification settings - Fork 288
Add support for importing Cobertura coverage file #805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments. Please add yourself to the Authors, update the changeling and add a test case.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #805 +/- ##
==========================================
- Coverage 94.44% 94.24% -0.21%
==========================================
Files 41 42 +1
Lines 4108 4220 +112
Branches 809 827 +18
==========================================
+ Hits 3880 3977 +97
- Misses 147 158 +11
- Partials 81 85 +4
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGFM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please can you add a test case for this?
I did already add a test case. Are you wanting another one? Or are you saying the current test case doesn't have enough coverage? |
|
Sorry, I missed this test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGFM
Co-authored-by: Michael Förderer <[email protected]>
This PR adds the
--cobertura-add-tracefileoption to the CLI. This options works just like the existing--json-add-tracefileoption, and both options can be used together.A couple of things to note about importing a Cobertura XML
resolves #803
This is a draft PR, as I still need to add test cases. However I am unfamiliar with the testing framework used and would appreciate some guidance in writing the tests.