-
Notifications
You must be signed in to change notification settings - Fork 288
Use different color for partial covered lines #839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #839 +/- ##
=======================================
Coverage 95.65% 95.65%
=======================================
Files 44 44
Lines 4347 4347
Branches 852 852
=======================================
Hits 4158 4158
Misses 111 111
Partials 78 78
☔ View full report in Codecov by Sentry. |
|
hey @Spacetown, |
|
You can directly install my branch with pip as described here |
9ea04d3 to
4842b57
Compare
4842b57 to
8c9346f
Compare
|
Hey @Spacetown I was able to test this out and looks good however, I did notice some areas of code not getting a definition of coverage. the break would showup as white |
|
If this is an issue with gcovr and not this feature then Its probably OK. |
|
Ok this looks like just a general gcovr or my code issue totally separate. |
|
@RatMan64 Can you add a review comment? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good and works as expected.
|
Something went wrong with this merge? A couple of top-level directories appeared that should probably be part of the test suite? |
|
I'll fix this. |
Remove files added by accident with #839
* Change stylesheet to show partial coverage
…ident Remove files added by accident with gcovr#839
Use a different color in HTML report if not all branches in a line are covered.
In GitHub theme the excluded lines where green which was confusing with the covered lines in green theme.
Closes #838