-
Notifications
You must be signed in to change notification settings - Fork 288
Don't loose stderr and stdout of gcovr for non-zero return code #956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Now we only see the last output. I think a better solution is to keep the local variables and add them to the exception text. In the error output they should not be used if set to None. |
aade25b to
1aa9677
Compare
|
|
Can you print the output after the error message? |
1aa9677 to
247fbcd
Compare
Done. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGFM. Thanks for fixing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGFM. Thanks for fixing this.
…r#956) --------- Co-authored-by: Michael Förderer <[email protected]>
I try to fix next message
We lose stdout and stderr when return code of gcov is not 0 or 6, so all useful information lost ( I used strace tool to get messages).
Now, stdout and stderr are saved in object for sure