Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Spacetown
Copy link
Member

For some branches the block number is missing in gcov test output file. Assume block 0 in this case to prevent None as block number in LCOV files.

Closes #973

@Spacetown Spacetown added this to the Upcoming release milestone Sep 30, 2024
@codacy-production
Copy link

codacy-production bot commented Sep 30, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00% (target: 95.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (97e51f1) 4176 4085 97.82%
Head commit (62c7e9f) 4184 (+8) 4093 (+8) 97.83% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#976) 8 8 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@Spacetown Spacetown force-pushed the assume_block_0_if_block_is_missing branch 2 times, most recently from 64197c7 to dfa0daa Compare September 30, 2024 21:06
@Spacetown Spacetown force-pushed the assume_block_0_if_block_is_missing branch from dfa0daa to 17b36b3 Compare October 1, 2024 15:49
As suggested in review we keep the invalid value in our data model and
ensure to have a valid value in the generated LCOV report.
@Spacetown Spacetown merged commit 67478e8 into gcovr:main Oct 1, 2024
35 checks passed
@Spacetown Spacetown deleted the assume_block_0_if_block_is_missing branch October 1, 2024 17:24
@Spacetown Spacetown removed this from the Upcoming release milestone Oct 8, 2024
D-Walther pushed a commit to D-Walther/gcovr that referenced this pull request Jun 16, 2025
Keep invalid blockno in data model:
As suggested in review we keep the invalid value in our data model and
ensure to have a valid value in the generated LCOV report.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gcovr with --lcov output does not seem compliant with lcov

2 participants