source/dcell/common.d (1)

16-22: Comment is incomplete for Windows support.

The doc comment mentions only POSIX (/dev/tty and $TERM), but TtyScreen() now handles Windows as well (via WinTty). Consider updating the comment to reflect cross-platform behavior.

 /**
- * Obtain a new screen. On POSIX this is connected to /dev/tty
- * using the $TERM environment variable.
+ * Obtain a new screen. On POSIX this is connected to /dev/tty
+ * using the $TERM environment variable. On Windows this uses
+ * the console APIs.
  */

source/dcell/termio.d (2)

127-128: Minor typo in comment.

-        // If cores.sys.posix.sys.ioctl had more complete and accurate data...
+        // If core.sys.posix.sys.ioctl had more complete and accurate data...

---

232-233: Minor typo: "clearning" → "clearing".

-            // this can fail, we're just clearning the signaled state
+            // this can fail, we're just clearing the signaled state

source/dcell/wintty.d (2)

139-141: Check return value of ReadConsoleInputW.

The return value indicates success/failure but is ignored. While the error path may be rare, consider validating the call succeeded before processing the records.

-            ReadConsoleInput(input, recs.ptr, 128, &nrec);
+            if (!ReadConsoleInputW(input, recs.ptr, 128, &nrec))
+                return result;

---

61-66: Consider checking CreateEventW result.

CreateEventW can fail and return NULL. Adding validation would improve robustness:

 this()
 {
     input = GetStdHandle(STD_INPUT_HANDLE);
     output = GetStdHandle(STD_OUTPUT_HANDLE);
     eventH = CreateEventW(null, true, false, null);
+    if (eventH is null)
+        throw new Exception("Failed to create event handle");
 }

Note: This would require removing @nogc nothrow or using a different error handling strategy.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: gdamore
Repo: gdamore/dcell PR: 27
File: source/dcell/ttyscreen.d:763-766
Timestamp: 2025-12-08T19:10:45.993Z
Learning: In source/dcell/ttyscreen.d, the newTtyScreen() factory function intentionally does not accept a term parameter because the TtyScreen constructor handles environment variable resolution internally with an optional term parameter. Users needing to override the terminal type should call the constructor directly: new TtyScreen(newDevTty(), "custom-term").

Learnt from: gdamore
Repo: gdamore/dcell PR: 27
File: source/dcell/ttyscreen.d:763-766
Timestamp: 2025-12-08T19:10:45.993Z
Learning: In source/dcell/ttyscreen.d, the newTtyScreen() factory function intentionally does not accept a term parameter because the TtyScreen constructor handles environment variable resolution internally with an optional term parameter. Users needing to override the terminal type should call the constructor directly: new TtyScreen(newDevTty(), "custom-term").

Learnt from: gdamore
Repo: gdamore/dcell PR: 27
File: source/dcell/ttyscreen.d:448-494
Timestamp: 2025-12-08T19:17:33.678Z
Learning: In source/dcell/ttyscreen.d, Color.reset is defined as a value above the range of valid colors. In the sendColors() function, after emitting the reset sequence (vt.resetFgBg), Color.reset values naturally skip all subsequent color-setting logic (isRGB checks and palette range checks < 8, < 256) because they are out of range, which is the correct behavior by design.