.github/workflows/ldc.yml (1)

34-57: Consider refactoring to reduce duplication.

These demo build steps follow the same repetitive pattern as in dmd.yml. Applying a similar matrix-based or loop-based approach would improve maintainability.

Refer to the refactoring suggestions in the dmd.yml review, which apply equally here. The verification script from dmd.yml will also confirm that all referenced demo directories exist.

.github/workflows/dmd.yml (1)

34-57: Consider refactoring repetitive demo builds for maintainability.

The demo build steps are functional but create significant duplication. All referenced demo directories (clipboard, colors, hello, mouse, styles) exist and are correctly named.

Consider using a matrix strategy to reduce duplication:

      - name: Build demos
        run: |
          for demo in clipboard colors hello mouse styles; do
            cd demos/$demo
            dub build
            cd ../..
          done

Or with GitHub Actions matrix:

  build-demos:
    needs: build
    strategy:
      matrix:
        os: [ubuntu-latest, windows-latest]
        dc: [dmd-latest]
        demo: [clipboard, colors, hello, mouse, styles]
    runs-on: ${{ matrix.os }}
    steps:
      - name: Checkout Source
        uses: actions/checkout@v6
      - name: D Compiler Installation
        uses: dlang-community/setup-dlang@v2
        with:
          compiler: ${{ matrix.dc }}
      - name: Build ${{ matrix.demo }} demo
        working-directory: demos/${{ matrix.demo }}
        run: dub build

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

.github/workflows/build.yml (2)

18-22: Consider documenting the exclusion rationale.

The matrix excludes macos-latest with dmd-latest and windows-latest with ldc-latest. Adding a brief comment explaining why these combinations are excluded would help future maintainers understand the testing strategy.

         exclude:
+          # DMD not tested on macOS; LDC not tested on Windows
           - os: macos-latest
             dc: dmd-latest
           - os: windows-latest
             dc: ldc-latest

---

39-47: Improve error handling and directory navigation.

The demo build loop has several reliability concerns:

• If a demo directory doesn't exist, cd fails silently and dub build runs in the wrong location
• No verification that demo directories exist before attempting to build
• Relative path navigation assumes exact depth

Apply this diff to add fail-fast error handling:

       - name: Build Demos
         shell: bash
         run: |
+          set -e
           for demo in clipboard colors hello mouse styles;
           do
-            cd demos/$demo
-            dub build || exit 1
-            cd ../..
+            pushd "demos/$demo"
+            dub build
+            popd
           done

The improvements:

• set -e makes the script exit immediately on any error (including failed cd)
• pushd/popd is more robust than cd with relative paths
• Quotes around the path handle edge cases with spaces
• The || exit 1 is redundant with set -e

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro