Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
utilfiles are currently intertwined with thentypesfiles through theComplexdatatype, as sometimes we need to call Lua binding functions with eitherdoubles orComplex!doubles. This also causes a duplication of some Lua bindings & functions. With the potential introduction ofDualnumbers as an alternative adjoint computation method, this would introduce more duplication.This merge proposes the use of limited templates, to remove the duplication, and allow for the
utilfiles to be decoupled from specific number types. The traitcanCastTois introduced, which allows compile-time checks if a type can be cast to another, either explicitly (using thecast(T)orto!(T)notation) or implicitly (by sub-typing). This is similar to the traitsisFloatingandisIntegral, however those cannot be extended to user-defined types.