Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@alebrigant
Copy link
Collaborator

Explain optimal matching algorithm.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #1180 (ba5c870) into master (36431fa) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1180      +/-   ##
==========================================
- Coverage   94.54%   94.52%   -0.02%     
==========================================
  Files          89       89              
  Lines        8895     8895              
==========================================
- Hits         8409     8407       -2     
- Misses        486      488       +2     
Flag Coverage Δ
autograd 80.53% <ø> (-0.02%) ⬇️
numpy 77.86% <ø> (+0.02%) ⬆️
pytorch 76.54% <ø> (-0.01%) ⬇️
tensorflow 72.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
geomstats/learning/kmeans.py 85.72% <0.00%> (-1.78%) ⬇️
geomstats/learning/expectation_maximization.py 87.78% <0.00%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36431fa...ba5c870. Read the comment docs.

@ninamiolane ninamiolane self-requested a review October 14, 2021 20:30
Copy link
Collaborator

@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you so much for the additional details!

@ninamiolane ninamiolane merged commit 5d47888 into geomstats:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants