Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add tests for geodesic regression on Euclidean space (sanity check) and DiscreteCurves #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 14, 2022
Merged

Add tests for geodesic regression on Euclidean space (sanity check) and DiscreteCurves #1576

merged 7 commits into from
Jun 14, 2022

Conversation

@ninamiolane
Copy link
Collaborator

@ninamiolane ninamiolane commented Jun 14, 2022 •
edited
Loading

This PR:

  • adds unit-tests for geodesic regression on Euclidean space (sanity check)
  • following failures in the above unit-tests, adds parallel_transport method to Euclidean metric
  • adds unit-tests corresponding to the new parallel_transport method
  • sets up unit-tests for geodesic regression on DiscreteCurves (this fails in all backends)
  • following failures in the above unit-tests, adds projection method to DiscreteCurves
  • adds the unit-tests corresponding to the new projection method

Issue #1575 is one of the reasons why the unit-tests fail when performing geodesic regression on DiscreteCurves.

Checklist

  • My pull request has a clear and explanatory title.
  • If neccessary, my code is vectorized.
  • I have added apropriate unit tests.
  • I have made sure the code passes all unit tests. (refer to comment below)
  • My PR follows PEP8 guidelines. (refer to comment below)
  • My PR follows geomstats coding style and API.
  • My code is properly documented and I made sure the documentation renders properly. (Link)
  • I have linked to issues and PRs that are relevant to this PR.

@ninamiolane ninamiolane requested a review from luisfpereira June 14, 2022 17:08
@codecov
Copy link

codecov bot commented Jun 14, 2022 •
edited
Loading

Codecov Report

Merging #1576 (1db6d1c) into master (6f260f7) will increase coverage by 0.64%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1576      +/-   ##
==========================================
+ Coverage   89.23%   89.87%   +0.64%     
==========================================
  Files         107      107              
  Lines       10659    10611      -48     
==========================================
+ Hits         9511     9536      +25     
+ Misses       1148     1075      -73
Flag Coverage Δ
autograd ?
numpy 87.16% <100.00%> (?)
pytorch 79.74% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
geomstats/geometry/discrete_curves.py 78.99% <100.00%> (+0.28%) ⬆️
geomstats/geometry/euclidean.py 94.12% <100.00%> (+0.37%) ⬆️
geomstats/information_geometry/gamma.py 55.04% <0.00%> (-35.90%) ⬇️
geomstats/_backend/_common.py 75.00% <0.00%> (-25.00%) ⬇️
geomstats/geometry/hypersphere.py 80.91% <0.00%> (-7.11%) ⬇️
geomstats/learning/geodesic_regression.py 84.42% <0.00%> (-5.19%) ⬇️
geomstats/geometry/grassmannian.py 93.69% <0.00%> (-1.05%) ⬇️
geomstats/learning/frechet_mean.py 96.00% <0.00%> (-0.88%) ⬇️
geomstats/geometry/special_euclidean.py 88.68% <0.00%> (-0.24%) ⬇️
geomstats/_backend/autograd/__init__.py
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f260f7...1db6d1c. Read the comment docs.

@ninamiolane ninamiolane merged commit 6d66728 into geomstats:master Jun 14, 2022
@ninamiolane ninamiolane deleted the discrete-curves branch June 14, 2022 17:34
@ninamiolane ninamiolane mentioned this pull request Jun 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luisfpereira luisfpereira Awaiting requested review from luisfpereira

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ninamiolane