Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Refactor Closed Curves #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jun 30, 2022
Merged

Refactor Closed Curves #1596

merged 18 commits into from
Jun 30, 2022

Conversation

@ninamiolane
Copy link
Collaborator

@ninamiolane ninamiolane commented Jun 27, 2022 •
edited
Loading

This PR addresses issue #1485 :

  • by renaming the method project into projection,
  • allowing the projection method to work for minibatches of curves (using a for loop at the moment).

This PR continues to address #1486 :

  • by removing ClosedSRVMetric which only had srv_project as a method, which essentially relies on the srv_transform and not necessarily the SRV metric.

We now have only two spaces (Manifolds):

  • DiscreteCurves
  • ClosedDiscreteCurves,

with different Metrics

  • L2CurvesMetric
  • ElasticMetric
  • SRVMetric
  • QuotientSRVMetric
    and each of the metric is equipping these spaces.

This PR does not impact the QuotientSRVMetric.

Checklist

  • My pull request has a clear and explanatory title.
  • If neccessary, my code is vectorized.
  • I have added apropriate unit tests.
  • I have made sure the code passes all unit tests. (refer to comment below)
  • My PR follows PEP8 guidelines. (refer to comment below)
  • My PR follows geomstats coding style and API.
  • My code is properly documented and I made sure the documentation renders properly. (Link)
  • I have linked to issues and PRs that are relevant to this PR.

Description

Issue

Additional context

@ninamiolane ninamiolane marked this pull request as draft June 27, 2022 19:41
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@codecov
Copy link

codecov bot commented Jun 27, 2022 •
edited
Loading

Codecov Report

Merging #1596 (7f6716f) into master (783ad01) will increase coverage by 0.36%.
The diff coverage is 92.93%.

@@            Coverage Diff             @@
##           master    #1596      +/-   ##
==========================================
+ Coverage   90.80%   91.15%   +0.36%     
==========================================
  Files         108      112       +4     
  Lines       10375    10946     +571     
==========================================
+ Hits         9420     9977     +557     
- Misses        955      969      +14
Flag Coverage Δ
autograd 88.59% <92.93%> (+0.02%) ⬆️
numpy 87.07% <92.93%> (+0.09%) ⬆️
pytorch 80.31% <92.93%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
geomstats/geometry/discrete_curves.py 88.60% <92.93%> (+0.18%) ⬆️
geomstats/_backend/pytorch/autodiff.py 98.12% <0.00%> (ø)
geomstats/_backend/pytorch/random.py 80.96% <0.00%> (ø)
geomstats/_backend/pytorch/linalg.py 84.62% <0.00%> (ø)
geomstats/_backend/pytorch/__init__.py 96.02% <0.00%> (ø)
geomstats/learning/expectation_maximization.py 80.56% <0.00%> (+0.56%) ⬆️
geomstats/learning/geodesic_regression.py 85.72% <0.00%> (+1.95%) ⬆️
geomstats/geometry/stratified/wald_space.py 90.22% <0.00%> (+2.56%) ⬆️
geomstats/tests.py 84.75% <0.00%> (+16.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 783ad01...7f6716f. Read the comment docs.

@ninamiolane ninamiolane marked this pull request as ready for review June 28, 2022 05:24
@ninamiolane
Copy link
Collaborator Author

The failing tests are not related to this PR.

@ninamiolane ninamiolane requested a review from alebrigant June 28, 2022 05:24
alebrigant
alebrigant approved these changes Jun 30, 2022
View reviewed changes
Copy link
Collaborator

@alebrigant alebrigant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks all good to me ! Thanks, this refactoring was much needed !

@ninamiolane ninamiolane merged commit 6327307 into geomstats:master Jun 30, 2022
@ninamiolane ninamiolane deleted the closed-curv branch June 30, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alebrigant alebrigant alebrigant approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ninamiolane @alebrigant