Merge #1767, #1885, #1890, and #1894 together #1895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rTriangularMatrices
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
da0920b to
b98d333
Compare
Codecov Report
@@ Coverage Diff @@
## master #1895 +/- ##
==========================================
+ Coverage 88.57% 90.98% +2.42%
==========================================
Files 141 221 +80
Lines 13744 19431 +5687
==========================================
+ Hits 12172 17678 +5506
- Misses 1572 1753 +181
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 46 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
d596284 to
9c8e907
Compare
a46b244 to
2aba46a
Compare
ninamiolane
approved these changes
Oct 25, 2023
2aba46a to
ab8c591
Compare
…s, and increase global tolerance
ab8c591 to
dce6c5f
Compare
1bd0da3 to
9aed541
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created separated PRs for #1767, #1885, #1890, and #1894 to show changes to particular modules together:
Refactor tests #1767: refactor tests
Fixes and improvements coming from test refactoring (part 4) #1885: fixes in
geometryFix and clean information geometry #1890: clean and fix
information_geometryFix and clean learning module #1894: fixes in
learningTo avoid having to update old tests for #1885, #1890, and #1894, I'm suggesting to merge all of them together. Notice this is a milestone in
geomstatsas we will now start using the new testing framework (most of old tests were fully ported to new style; there's a couple of files that still follow the old style, that I'll update when refactoring the corresponding code).P.S. Hope this is the last PR of this dimension!