-
-
Notifications
You must be signed in to change notification settings - Fork 610
Revert "Copyedit c14" #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Sorry if I jumped the gun. All the changes looked good. This PR seems to revert good changes. |
|
that's fine, the changes will be added again when I am done adding all changes, no worries |
|
will add all changes within the next hour and will let you know when I am done |
|
Just to explain, I stopped working on the chapter because I needed to take care of my Katharina as she is ill. Therefore, the impression arose that I might be done with the chapter when in fact I was only taking a break, sorry! |
|
Ok, finally I am done. Just one more thing, I also wrote it into #334: |
14-eco.Rmd
Outdated
| Additionally, the relationships might be highly non-linear. | ||
| In our use case, the relationship between response and predictors are pretty clear, there is only a slight amount of non-linearity and the number of observations and predictors is low. | ||
| Hence, it might be worth to try a linear model. | ||
| Hence, it might be worth it to try a linear model. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Robinlovelace Could you pls check this sentence, is it really it might be worth it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new version is definitely better. However, I would suggest this, which is shorter and clearer:
Hence, it might be worth trying a linear model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect, thank, Robin!
@jannes-m please add those kinds of issues to #334. We will need to work on them later. |
14-eco.Rmd
Outdated
| Ordinations are a popular tool in vegetation science to extract the main information, frequently corresponding to ecological gradients, from large species-plot matrices mostly filled with 0s. | ||
| However, they are also used in remote sensing, the soil sciences, geomarketing and many other fields. | ||
| If you are unfamiliar with ordination techniques or in need of a refresher, have a look at Michael W. Palmers [webpage](http://ordination.okstate.edu/overview.htm) for a short introduction to popular ordination techniques in ecology and at @borcard_numerical_2011 for a deeper look on how to apply these techniques in R. | ||
| If you are unfamiliar with ordination techniques or in need of a refresher, have a look at Michael W. Palmer' s [web page](http://ordination.okstate.edu/overview.htm) for a short introduction to popular ordination techniques in ecology and at @borcard_numerical_2011 for a deeper look on how to apply these techniques in R. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary space?
|
@jannes-m good to merge? |
Robinlovelace
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with these changes. We can fix minor issues, like https://github.com/Robinlovelace/geocompr/pull/357/files#r243570787 , post merge.
14-eco.Rmd
Outdated
| Additionally, the relationships might be highly non-linear. | ||
| In our use case, the relationship between response and predictors are pretty clear, there is only a slight amount of non-linearity and the number of observations and predictors is low. | ||
| Hence, it might be worth to try a linear model. | ||
| Hence, it might be worth it to try a linear model. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new version is definitely better. However, I would suggest this, which is shorter and clearer:
Hence, it might be worth trying a linear model.
Reverts #356
I still have to do some updates, i.e., I haven't finished yet.