-
Notifications
You must be signed in to change notification settings - Fork 664
Add input validation warnings to Point #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think that longitudes in the range |
|
But |
fa096ea to
58a37a8
Compare
58a37a8 to
a1333c0
Compare
|
I moved all the warnings from Distance to Point, which allowed to simplify the validation code significantly. For the reference, the previous commit was 58a37a8. I also decided to not complain about longitude normalization, because I believe there's nothing error-prone with that (unlike latitude). I'll leave it open for a day to reason a bit about this all, but I guess it's ready as-is. I would be glad if someone could review (especially the warning messages, as I'm not so confident with English). |
|
Ok, I refined one message a little. Now the warnings look like this: Well, I hope it won't break anything. Merging and prepping the |
This PR adds coordinates validation and issues warnings when they're invalid (or error-prone).
TODO:
Regarding performance degradation – it's ~1.2 times slower with Points and ~1.9 times slower with tuples for me. IMO it's tolerable.Related discussions: #245 #242 #202