Add address details for reverse Nominatim #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Changing default to True to preserve backward-compatibility. |
Member
KostyaEsmukov
left a comment
There was a problem hiding this comment.
Thanks! Could you please add a test for this change which ensures that with addressdetails=False there's indeed no extra info returned?
Besides missing tests it looks good to me!
geopy/geocoders/osm.py
Outdated
| .. versionadded:: 1.0.0 | ||
| :param bool addressdetails: Whether or not to include address details, | ||
| such as city, county, state, etc. in *Location.raw* |
Member
There was a problem hiding this comment.
Could you please indent this line? In a similar way as above.
Also it'd be great if you could add the .. versionadded:: 1.14.0 line below.
Contributor
Author
|
Changes done. Can you check the test is fine ? I'm not familiar with geopy's tests. |
KostyaEsmukov
approved these changes
Apr 26, 2018
Member
KostyaEsmukov
left a comment
There was a problem hiding this comment.
Yup, this is fine. Merging. Thank you!
Contributor
Author
|
YW, thanks for the quick merge ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick PR for #284
Actually forward geocoding already had the feature, but for some reason reverse geocoding always includes full address details. The default is now set to False.