Conversation
KostyaEsmukov
left a comment
There was a problem hiding this comment.
Thank you! This is so good that I was going to just merge it right away (despite the failing Travis build due to Google completely forbidding key-less API usage for timezones, which I'm going to fix in master soon), but I noticed a missing test case (I left a comment below).
Also I tried to sign up on https://geolake.com but I got an error which made me unable to proceed. Perhaps I'll try again later. Unfortunately I won't be able to merge this until after I obtain a working geolake account, otherwise I will not be able to test and maintain this code.
|
@KostyaEsmukov thanks for the rapid (and positive) review! Thanks for letting me know about the error on the sign up form and we're really sorry you had to run in to this. We've resolved this regression so this should not pose a problem again. I've also added the missed test scenario. |
KostyaEsmukov
left a comment
There was a problem hiding this comment.
Thanks! The error is definitely gone: I've successfully created an account and obtained an API key. The tests pass for me locally, so I'm merging this.
This implementation is going to be included in the upcoming 1.18 version for sure. Unfortunatelly I cannot promise any ETA for the new release, but I hope that the planned issues would be managed in the next ~2 weeks.
This PR adds support for the Geolake geocoding service, it'd be great if this could make it in to the next release. Please let me know if you'd like me to make any additional changes.