add extratags parameter for nominatim #320
Conversation
KostyaEsmukov
left a comment
There was a problem hiding this comment.
Thanks! I left some notes below, could you please address them?
Ignore the failed Travis build for py3.7 – that looks like a Travis fault; it's definitely not caused by your code.
geopy/geocoders/osm.py
Outdated
| language=False, | ||
| geometry=None | ||
| geometry=None, | ||
| extratags=True, |
There was a problem hiding this comment.
Could you please keep the old behavior (i.e. set the default value to False)? The extra info is rarely needed, so defaulting that to True means some pointlessly wasted cpu and network resources.
| :param bool extratags: Include additional information in the result if available, | ||
| e.g. wikipedia link, opening hours. | ||
There was a problem hiding this comment.
Could you please add the following line:
.. versionadded:: 1.17.0
test/geocoders/nominatim.py
Outdated
|
|
||
| def test_extratags(self): | ||
| """ | ||
| Nominatim.geocode using `extratags` |
There was a problem hiding this comment.
This docstring is not needed as it restates the test method name.
test/geocoders/nominatim.py
Outdated
| """ | ||
| Nominatim.geocode using `extratags` | ||
| """ | ||
| geocoder = Nominatim(user_agent='my_user_agent/1.0') |
There was a problem hiding this comment.
The tests above use self.make_geocoder() for creating an instance of geocoder. This is important, because this test class is an abstract class which tests not just Nominatim, but also other Nominatim-based geocoders (e.g. Pickpoint and OpenMapQuest), which instances are returned by the overridden make_geocoder methods in the specific test cases.
_make_request usage is also discouraged. The same could be achieved with the following (which also doesn't require creating a new geocoder instance):
query = "175 5th Avenue NYC"
location = self.geocode_run(
{"query": query},
{},
)
self.assertIsNone(result.raw.get('extratags'))
location = self.geocode_run(
{"query": query, "extratags": True},
{},
)
self.assertEqual(result.raw['extratags']['wikidata'], 'Q220728')
this commit fixes #157