Add geopy.Timezone -- a timezone wrapper#332
Merged
KostyaEsmukov merged 2 commits intomasterfrom Nov 4, 2018
Merged
Conversation
geopy.Timezone is a wrapper for pytz timezone and a raw geocoder response. I don't really like the new `reverse_timezone` method name, but I couldn't come up with a better idea of smooth transition from pytz.timezone as return type to geopy.Timezone rather than to rename the method.
ba98b88 to
28405f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently only GoogleV3 implements a query returning a timezone. It returns pytz.timezone directly, and the raw geocoder response is not accessible. This PR introduces a
geopy.Location-like wrapper for pytz.timezone --geopy.Timezone.For a smooth transition I decided to introduce a new
GoogleV3.reverse_timezonemethod, which is similar toGoogleV3.timezoneexcept that it returnsgeopy.Timezoneobject. I don't really like thereverse_timezonemethod name, but I couldn't come up with a better idea of smooth transition frompytz.timezone as return type to geopy.Timezone.
This feature came out from #327.