Thanks to visit codestin.com
Credit goes to github.com

Skip to content

added place_id search parameter for geocode method#348

Merged
KostyaEsmukov merged 1 commit intogeopy:masterfrom
mstoncel:fixtures_placeid
Mar 25, 2019
Merged

added place_id search parameter for geocode method#348
KostyaEsmukov merged 1 commit intogeopy:masterfrom
mstoncel:fixtures_placeid

Conversation

@mstoncel
Copy link
Contributor

No description provided.

Copy link
Member

@KostyaEsmukov KostyaEsmukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This change makes perfect sense to me, however there're some things that need to be addressed before this could be merged. I left some comments below.

Also, could you please add some tests? 3 tests should be enough, I guess:

  1. g.geocode() being called without any args should raise a ValueError
  2. g.geocode('london', place_id=42) should raise a ValueError (since 2 incompatible args are being specified)
  3. g.geocode(place_id=*some_valid_palce_id*) should return a valid Location, just like a plain g.geocode('some city') call.

Copy link
Member

@KostyaEsmukov KostyaEsmukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the edits! Just a couple more and I think it would be ready.

@KostyaEsmukov KostyaEsmukov added this to the 1.19 milestone Mar 23, 2019
Copy link
Member

@KostyaEsmukov KostyaEsmukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging, thanks!

@KostyaEsmukov KostyaEsmukov merged commit 71b7a84 into geopy:master Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments