added place_id search parameter for geocode method#348
Merged
KostyaEsmukov merged 1 commit intogeopy:masterfrom Mar 25, 2019
Merged
added place_id search parameter for geocode method#348KostyaEsmukov merged 1 commit intogeopy:masterfrom
KostyaEsmukov merged 1 commit intogeopy:masterfrom
Conversation
cad17d2 to
c51104a
Compare
Member
KostyaEsmukov
left a comment
There was a problem hiding this comment.
Thanks! This change makes perfect sense to me, however there're some things that need to be addressed before this could be merged. I left some comments below.
Also, could you please add some tests? 3 tests should be enough, I guess:
g.geocode()being called without any args should raise a ValueErrorg.geocode('london', place_id=42)should raise a ValueError (since 2 incompatible args are being specified)g.geocode(place_id=*some_valid_palce_id*)should return a valid Location, just like a plaing.geocode('some city')call.
07077df to
de87734
Compare
Member
KostyaEsmukov
left a comment
There was a problem hiding this comment.
Thank you for the edits! Just a couple more and I think it would be ready.
c689e56 to
9b155d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.