Add language parameter to the Pelias geocoder #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both methods `geocode` and `reverse` accept the `language` parameter which will be passed to the pelias-api as GET parameter `lang`. This applies to `GeocodeEarth` as well.
KostyaEsmukov
requested changes
Dec 17, 2019
Member
KostyaEsmukov
left a comment
There was a problem hiding this comment.
Thanks, looks good! Could you please fix the Travis CI errors?
Contributor
Author
|
@KostyaEsmukov I have corrected the lint errors. Now there is a problem with the yandex geocoder, which I did not touch. This problem obviously appeared in the last three months as the last test of master worked (https://travis-ci.org/geopy/geopy/builds/588060571?utm_medium=notification&utm_source=github_status) |
KostyaEsmukov
approved these changes
Dec 17, 2019
Member
KostyaEsmukov
left a comment
There was a problem hiding this comment.
Great, thank you! I'll deal with that Yandex failure later in master. This is good to go, merging.
Contributor
Author
|
Well, thank you very much for this great package! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both methods
geocodeandreverseaccept thelanguageparameter which will be passed to the pelias-api as GET parameterlang.This applies to
GeocodeEarthas well.