Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support here apikeys #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KostyaEsmukov merged 11 commits into from
Feb 2, 2020
Merged

Support here apikeys #388

KostyaEsmukov merged 11 commits into from
Feb 2, 2020

Conversation

@deeplook
Copy link
Contributor

@deeplook deeplook commented Feb 2, 2020

No description provided.

deeplook and others added 11 commits June 9, 2018 00:09
@deeplook
Initial commit of HERE geocoder
1c3b02f
@deeplook
Initial commit of HERE geocoder
497057a
@deeplook
Merge branch 'master' of github.com:deeplook/geopy
2139f37
@deeplook
Remove Unicode chars.
f4865c6
@deeplook
Adapt method signatures, adding specific param names
4345273
@deeplook
Make flake8 happy again
255fc0a
@KostyaEsmukov
Merge remote-tracking branch 'origin/master' into deeplook-master
f5442bc 
# Conflicts:
#	README.rst
#	docs/index.rst
@KostyaEsmukov
HERE: fix a typo: *è*xactly_one (which breaks py2)
664076e 
Python 2 error message:

SyntaxError: Non-ASCII character '\xc3' in file
.../geopy/geocoders/here.py on line 135, but no encoding declared;
see http://www.python.org/peps/pep-0263.html for details.
@KostyaEsmukov
Merge branch 'master' into deeplook-master
9bc3ee8 
# Conflicts:
#	test/geocoders/util.py
@deeplook
Merge remote-tracking branch 'upstream/master'
b9ae75f
@deeplook
Use new API keys
8cfe7a1
@deeplook deeplook mentioned this pull request Feb 2, 2020
Closed
@KostyaEsmukov
Copy link
Member

KostyaEsmukov commented Feb 2, 2020

Thank you! I'll merge this as-is, but will add some changes on top of master, such as:

  • the new apikey argument breaks backwards compatibility, so it should have a default value None and be located after app_id and app_code
  • tests should exercise both app_id+app_code and apikey options, not just one of them

But these are just little details, thanks again for providing a working fix!

@KostyaEsmukov KostyaEsmukov merged commit 35f2ea1 into geopy:master Feb 2, 2020
@deeplook
Copy link
Contributor Author

deeplook commented Feb 17, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@deeplook @KostyaEsmukov