googlev3: Add error_message to error checking #398
Conversation
* GoogleV3 API response contains an `error_message` field when `status` is not `OK`. This field contains various complementary information that helps to debug the issue with the provided geocoder query. https://developers.google.com/maps/documentation/geocoding/intro#ErrorMessages * This commit adds the content of the `error_message` field to the GeocoderQueryError exception in cases when `error_message` is provided in the API response and the exception is to be raised. Signed-off-by: mr.Shu <[email protected]>
d9b268a to
2faaf6b
Compare
|
@KostyaEsmukov @jbouvier This is just a friendly reminder that I'd be happy to address any comments you guys may have. Thanks! |
KostyaEsmukov
left a comment
There was a problem hiding this comment.
The contents of error_message has helped me to debug it much faster and so I believe it would be good to make it part of the exception that it being raised.
The error responses are already fed to the logger:
Lines 370 to 371 in 61bbab8
But I guess you didn't have them, because Google geocoder seems to respond with 200 status for errors instead of 4xx.
What bothers me with this solution is that the parts (the one from geopy and the other from API) of the resulting concatenated error messages would probably duplicate each other or even contradict to each other, causing confusion.
So I'd prefer to solve this problem other way:
- Either add logging of raw response bodies for errors in
_check_status, like in the link above - Or remove geopy's error messages and always passthrough the error message from API, like here: But in this option we need to be sure that the error messages from API are not less informative than the ones we have now.
geopy/geopy/geocoders/arcgis.py
Line 205 in 61bbab8
|
e1c00c4 should fix the issue: the API's |
Hello everyone,
First of all, thanks a ton for putting
geopytogether!While playing with the
geocodermodule and setting up GoogleV3 API, I ran into a few issues. The contents oferror_messagehas helped me to debug it much faster and so I believe it would be good to make it part of the exception that it being raised.I am not sure if I followed the standards of the
geopycodebase, so please feel free to point that out and I'd be happy to refactor the PR to reflect it better.Thanks!
GoogleV3 API response contains an
error_messagefield whenstatusisnot
OK. This field contains various complementary information thathelps to debug the issue with the provided geocoder query.
https://developers.google.com/maps/documentation/geocoding/intro#ErrorMessages
This commit adds the content of the
error_messagefield to theGeocoderQueryError exception in cases when
error_messageis providedin the API response and the exception is to be raised.
Signed-off-by: mr.Shu [email protected]