Allow multiple components of the same type in Googlev3. #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KostyaEsmukov
approved these changes
May 9, 2020
Member
KostyaEsmukov
left a comment
There was a problem hiding this comment.
Looks good, merging. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to address #407
This PR will allow GoogleV3 queries to accept a list of tuples as the component value. This should make it possible to add multiple constraints using the same component type. This change should not break the existing functionality of providing a dict with components.
Tests in
test/geocoders/googlev3.pyhave also been updated.The function will raise a
ValueErrorif the input for thecomponentsparameter is not of typelistordictE.g.: