remove unneded 'or None' that caused crashes #439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am a bit worried as I am unsure why this part of code was added but this change is not causing any tests to fail and it fixes #436 this part of code was already in initial commit adding support to Photon, so maybe it was simply a mistake (it was not added as an explicit workaround or fix)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am a bit worried as I am unsure why this part of code was added
but this change is not causing any tests to fail and it fixes #436
this part of code was already in initial commit adding support to Photon,
so maybe it was simply a mistake (it was not added as an explicit workaround or fix)