Quash TypeError potentially raised by requests -> urllib3 #488
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quashes an error raised by requests -> urllib3 -> stdlib:queue -> stdlib:threading where a pool may be done in a thread and therefore no object to close. Error encountered in both Python 3.7.8 on Windows 10 and 3.7.11 on Debian 10 ( Docker: python3.7-slim). Exception ignored in: <function RequestsAdapter.__del__ at 0x7fd2c3fee170> Traceback (most recent call last): File "/usr/local/lib/python3.7/site-packages/geopy/adapters.py", line 431, in __del__ File "/usr/local/lib/python3.7/site-packages/requests/sessions.py", line 747, in close File "/usr/local/lib/python3.7/site-packages/requests/adapters.py", line 325, in close File "/usr/local/lib/python3.7/site-packages/urllib3/poolmanager.py", line 222, in clear File "/usr/local/lib/python3.7/site-packages/urllib3/_collections.py", line 100, in clear File "/usr/local/lib/python3.7/site-packages/urllib3/poolmanager.py", line 173, in <lambda> File "/usr/local/lib/python3.7/site-packages/urllib3/connectionpool.py", line 490, in close File "/usr/local/lib/python3.7/queue.py", line 181, in get File "/usr/local/lib/python3.7/threading.py", line 348, in notify TypeError: 'NoneType' object is not callable
KostyaEsmukov
approved these changes
Aug 14, 2021
Member
KostyaEsmukov
left a comment
There was a problem hiding this comment.
Good workaround, thank you!
KostyaEsmukov
requested changes
Aug 14, 2021
Member
KostyaEsmukov
left a comment
There was a problem hiding this comment.
@tigerhawkvok Could you please fix the linting errors?
geopy/adapters.py:434:71: W291 trailing whitespace
geopy/adapters.py:437:66: W291 trailing whitespace
tigerhawkvok
commented
Aug 16, 2021
Contributor
Author
tigerhawkvok
left a comment
There was a problem hiding this comment.
Trimmed the two lines of whitespace raised by linter
KostyaEsmukov
approved these changes
Aug 16, 2021
Member
|
Perfect, thanks again! |
sthagen
added a commit
to sthagen/geopy-geopy
that referenced
this pull request
Aug 16, 2021
Quash TypeError potentially raised by requests -> urllib3 (geopy#488)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quashes an error raised by requests -> urllib3 -> stdlib:queue -> stdlib:threading where a pool may be done in a thread and therefore no object to close.
Error encountered in both Python 3.7.8 on Windows 10 and 3.7.11 on Debian 10 ( Docker: python3.7-slim).
Exception ignored in: <function RequestsAdapter.del at 0x7fd2c3fee170>
Traceback (most recent call last):
File "/usr/local/lib/python3.7/site-packages/geopy/adapters.py", line 431, in del
File "/usr/local/lib/python3.7/site-packages/requests/sessions.py", line 747, in close
File "/usr/local/lib/python3.7/site-packages/requests/adapters.py", line 325, in close
File "/usr/local/lib/python3.7/site-packages/urllib3/poolmanager.py", line 222, in clear
File "/usr/local/lib/python3.7/site-packages/urllib3/_collections.py", line 100, in clear
File "/usr/local/lib/python3.7/site-packages/urllib3/poolmanager.py", line 173, in
File "/usr/local/lib/python3.7/site-packages/urllib3/connectionpool.py", line 490, in close
File "/usr/local/lib/python3.7/queue.py", line 181, in get
File "/usr/local/lib/python3.7/threading.py", line 348, in notify
TypeError: 'NoneType' object is not callable