Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update URL and endpoint in DataBC geocoder #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KostyaEsmukov merged 1 commit into from
Aug 26, 2023
Merged

Update URL and endpoint in DataBC geocoder #557

KostyaEsmukov merged 1 commit into from
Aug 26, 2023

Conversation

@nickpcrogers
Copy link
Contributor

@nickpcrogers nickpcrogers commented Aug 24, 2023 •
edited
Loading

Note that this is a breaking change for people trying to use plain http at DataBC, however that should already be broken for them (at least it was for me)

Per DataBC documentation, the URL used in geopy was deprecated in 2018 and should have been shut down in December 2020:

December 1, 2020
The following URLs were deprecated on Sep. 1, 2018 and are now shut down:

http://apps.gov.bc.ca/pub/geocoder
https://apps.gov.bc.ca/pub/geocoder
This URL should now be used, with or without an API key: https://geocoder.api.gov.bc.ca

These endpoints have apparently continued to silently work, until August 22, 2023, when DataBC has started bouncing plain http requests at the old URL/endpoint.

This change updates the URL, and raises ConfigurationError if the DataBC geocoder is initialized with scheme='http'.

@KostyaEsmukov KostyaEsmukov merged commit 7c0cbf4 into geopy:master Aug 26, 2023
@KostyaEsmukov
Copy link
Member

KostyaEsmukov commented Aug 26, 2023

Thank you!

It appears that they have (perhaps temporarily) rolled back support for the old domain, as it is currently working for me.

I merged your change without the scheme check, because http seems to work even with the new domain. It's still a redirection to https, but at least it's not a breaking change anymore.

@KostyaEsmukov KostyaEsmukov mentioned this pull request Aug 26, 2023
Closed
@KostyaEsmukov KostyaEsmukov added this to the 2.4 milestone Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.4

Development

Successfully merging this pull request may close these issues.

2 participants

@nickpcrogers @KostyaEsmukov