Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Apr 16, 2024. It is now read-only.

Prepare changelog for bugfix & tweak release 0.8 #879

Merged
merged 9 commits into from
Oct 29, 2018
Merged

Prepare changelog for bugfix & tweak release 0.8 #879

merged 9 commits into from
Oct 29, 2018

Conversation

@kesselb
Copy link
Contributor

@kesselb kesselb commented Oct 18, 2018

@kesselb kesselb force-pushed the feature/noid/changelog-0.8-release branch 4 times, most recently from d0d00c6 to 826ac64 Compare October 20, 2018 20:40
@coveralls
Copy link

coveralls commented Oct 21, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 260

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.57%
Totals Coverage Status
Change from base Build 246: 0.0%
Covered Lines: 1723
Relevant Lines: 2236
💛 - Coveralls

torss
torss suggested changes Oct 23, 2018
View reviewed changes
Copy link
Collaborator

@torss torss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes of this PR seem fine, but I noticed that the link for 0.7.0 is broken, because the tag of that release (abnormally) doesn't have a v prefix.
So we should either adjust that URL in the changelog, or rename the release tag from 0.7.0 to v0.7.0 (the latter of which is preferable, if it is possible to rename it without any issues).
(Also note that I lack the knowledge to really comment on the UPGRADE.md re. correctness.)

@torss
Copy link
Collaborator

torss commented Oct 23, 2018 •
edited
Loading

So I guess we can't simply rename the release tag, right?

@kesselb
Copy link
Contributor Author

kesselb commented Oct 23, 2018

I changed the link. I'm not sure what happens when i rename the tag. E.g. travis builds only v\d.\d.\d

geli/.travis.yml

Line 33 in a6a1dd8

- /^v(\d+).(\d+).(\d+)$/

@kesselb kesselb force-pushed the feature/noid/changelog-0.8-release branch from 09fe657 to 09dcc7d Compare October 23, 2018 14:15
@torss
Copy link
Collaborator

torss commented Oct 23, 2018 •
edited
Loading

(The tag has now been changed, there were no known issues, see the mpse-geli/dev Gitter. ^^)

@kesselb kesselb mentioned this pull request Oct 23, 2018
Merged
@kesselb kesselb added blocked This Issue is blocked or can't be solved yet next release This issue will be solve/implemented in the next release labels Oct 29, 2018
@kesselb kesselb merged commit bd50379 into develop Oct 29, 2018
@kesselb kesselb deleted the feature/noid/changelog-0.8-release branch October 29, 2018 21:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dboschm dboschm Awaiting requested review from dboschm

@grosspersky grosspersky Awaiting requested review from grosspersky

@lukas-schardt lukas-schardt Awaiting requested review from lukas-schardt

@PatrickSkowronek PatrickSkowronek Awaiting requested review from PatrickSkowronek

@MichaelNarkus MichaelNarkus Awaiting requested review from MichaelNarkus

2 more reviewers

@Gargamil Gargamil Gargamil approved these changes

@torss torss torss approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

blocked This Issue is blocked or can't be solved yet next release This issue will be solve/implemented in the next release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kesselb @coveralls @torss @Gargamil