GCP subnet and separate buckets #2048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is related to work in griffith-lab/cloud-workflows repo. The intention behind splitting buckets is to apply separate lifecycle rules so input files stick around but execution files are deleted after 30 days
…parate-buckets
|
I did a test run with somatic_exome that went all the way through as expected |
|
Remove separate buckets, @chrisamiller and I talked a bit and decided on single bucket with expiry rule. Example data and large static files (e.g. vep_cache) handled separately |
| my $contents = <<"EOCONFIG" | ||
| { | ||
| "final_workflow_log_dir": "gs://$cromwell_gcp_bucket/build.$build_id/logs", | ||
| "final_workflow_log_dir": "gs://$cromwell_gcp_bucket/build.$build_id"/logs, |
There was a problem hiding this comment.
is this quotation mark supposed to be inside the slash or at the end?
There was a problem hiding this comment.
This quote is haunting me. I have no idea why it keeps changing back but this will be the fourth time I've fixed it?
There was a problem hiding this comment.
Ugh it was just my last push didn't go through
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes to reflect different infrastructure for GCP runs
separate buckets for inputs and executions files. also handled by initial setup, different buckets have different lifecycle rules so execution files which are no longer needed can be expired out without losing inputs which may be reused consistently. output files expected to be pulled to local storage, not persisted between buckets