fix: Update Python SDK docs to reflect actual API structure #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove non-existent BioMCPClient class references - Add correct modular import patterns (biomcp.variants.search, etc.) - Update all examples to use working API structure - Add LangChain integration example - Clarify differences between documented vs actual API Fixes issue where users couldn't import BioMCPClient as documented. The actual package uses individual domain modules, not a unified client.
- Add back get_variant() function that was incorrectly removed - Add back predict_variant_effects() AlphaGenome function - Fix VariantQuery parameter names (max_frequency not frequency_max, cadd not cadd_score_min) - Add missing VariantQuery fields: hgvsp, hgvsc, region, polyphen, sift, sources, size, offset - Correct examples to use proper parameter names - Update import patterns to include getter and alphagenome modules This corrects the overly aggressive removal of legitimate API functions and ensures documentation matches the actual code structure.
Clinical trial NCT04280705 references have been updated in the ClinicalTrials.gov database. Updated test expectations to match current data: - First reference PMID: 34473343 -> 38657001 - Second reference PMID: 34350582 -> 37466213 This fixes the failing BDD test in CI/prod environments.
jyeakley
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where users couldn't import BioMCPClient as documented. The actual package uses individual domain modules, not a unified client.