fix(#175): camt.054 Ntfctn>CreDtTm is optional
#176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PowerKiKi
requested changes
Aug 26, 2025
There was a problem hiding this comment.
I simplified the tests for you. But before merging I would like to be sure that the fallback mechanism is indeed dictated by the specification. I suspect it we should not automate that mechanism inside this library, and instead let the end-user handle the situation as they see fit.
…d of using fallback
Required `createdOn`: - `Statement` - `Report` Optional `createdOn`: - `Notification`
|
I pushed commits too, because other classes must keep |
|
(As long as the) Tests run fine, this is absolutely ok with me |
|
Released as https://github.com/genkgo/camt/releases/tag/2.10.3 Thank you for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes keeps the camt parser from throwing on optinal DateTime fields