Stateful potentials API #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
7a79974 to
223692c
Compare
This adds an implementation of a stateful API for potentials, where rather than a potential being represented as a pure function, it can maintain state. At present this is solely designed to expose the old API through a caching layer. For potentials that are expensive to compute from scratch this may be a performance gain to use, but otherwise has relatively few advantages over the old way of defining things, although in some cases it may be more convenient to implement something using the streaming API.
This reimplements the JSON potential on top of the stateful API, allowing it to incrementally read the incoming bytes rather than restarting from scratch each time.
223692c to
cf6a286
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new APIs for implementing potentials in a stateful way. That is, rather than treating the potential as always starting from scratch, it can maintain state between invocations.
Currently this just implements the old potential API in terms of the new one, with the intention that later work will rebuild the SMC algorithm on top of the stateful API, which will allow for much more efficient use.