-
Notifications
You must be signed in to change notification settings - Fork 219
Replacing "test main" by gmock_main #3019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@KarlStraussberger , could you help understanding why the CI is failing? gmock_main is a target available with vanilla googletest. |
|
I think it's got to be |
Weird... in the "official" GTestTargets.cmake (supplied with googletest) and available by default in my development Docker container (which is based on https://github.com/gerbera/gerbera/blob/master/Dockerfile) its "GTest::gmock_main" (not to add it works on my machine :-) ). The problem probably is in If I replace GTest::gmock_main with GMock::gmock_main it does not work in my container (probably will work in the CI). The question is, what's different in the CI build? It seems to use an different version of cmake or googletest... |
|
So... it's a cmake version issue... see: |
046da14 to
806f7fa
Compare
|
OK, there seems to be something with the conan build. I can also see some warnings about using deprecated functions in the log... |
|
I already started migrating to conan2, but it's not as straighforward as it should be. |
|
No worries. We can leave this PR open until then... |
|
Now you can try your changes. Conan2 was really a stubborn mule. |
22a5e9b to
f614edf
Compare
|
@KarlStraussberger , I'm not an expert in conan. It seems that the installed gtest/gmock package is built in Release, while in the CI Job we are building in Debug so it cannot link to libgmockd... not sure how to solve and why it's working without the GTest::gmock_main target |
|
We have |
|
I hope I find some time soon to work again on this :-) |
No description provided.