SOLR-16394: Tweak v2 restore-coll to be more REST-ful #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) This commit makes various cosmetic improvements to Solr's v2 create alias API, to bring it more into line with the more REST-ful direction we're targeting for our v2 API. The v2 API is now available at: `POST /api/aliases`. The request body has also been restructured slightly: the top-level "create-alias" command property has been removed, the router "name" field has been renamed to "type", and routers now are always defined in a list. This commit also migrates the API to JAX-RS.
…alized with another http2 client (apache#1587)
This commit tweaks the v2 binding for our "restore collection" API to be
more intuitive for users. Restore now lives at:
- POST /api/backups/backupName {...}
This commit also switches it over to using the JAX-RS framework.
9a4e5f0 to
5148904
Compare
…pache#1577) Add the option in AffinityPlacementFactory to spread replicas across domains within each AZ. Optionally, the request can fail if more than a configurable number of replicas will be placed in a single spread domain --------- Co-authored-by: Houston Putman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16394
Description
Solr is currently making slow progress in moving its v2 APIs in a more REST-ful direction. Many APIs have been improved, but many remaining including the API to restore to a new or existing collection.
Solution
This commit makes various cosmetic improvements to Solr's v2 restore-collection API, to bring it more into line with the more REST-ful v2 design. This mostly consists of moving the API under the
/api/backups/backupNamepath, and removing the top-level "command" specification from the request body.Tests
Existing tests continue to pass. New unit tests in RestoreCollectionAPITest.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.