[Freepilot] feat: clarify sats millisats #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated get_balance tool description to explicitly mention millisatoshis in return value - Added Zod schema validation for get_balance response with clear unit description - Enhanced descriptions in make_invoice and pay_invoice tools to use 'millisatoshis (millisats)' for clarity - Fixed fiat_to_sats tool description (input amount should be fiat, not sats) - Added response schema validation for fiat_to_sats tool - Updated request_invoice tool to explicitly state amount is in satoshis (sats) - Improved AI understanding by using full unit names with common abbreviations in parentheses This addresses the confusion between sats and millisats that AI sometimes experiences by making units explicit throughout tool descriptions and adding proper schemas.
rolznz
reviewed
Jun 20, 2025
src/tools/nwc/pay_invoice.ts
Outdated
| amount: z | ||
| .number() | ||
| .describe("Optional amount in millisats to pay a zero-amount invoice") | ||
| .describe("Optional amount in millisatoshis (millisats) to pay a zero-amount invoice") |
There was a problem hiding this comment.
TODO: also state the fees are in millisats
rolznz
reviewed
Jun 20, 2025
src/tools/lightning/fiat_to_sats.ts
Outdated
| import { z } from "zod"; | ||
|
|
||
| // Define Zod schema for the response - returns number of satoshis | ||
| const FiatToSatsResponseSchema = z.number().describe("Amount in satoshis (sats)"); |
There was a problem hiding this comment.
I don't think this is the right way - there should be a way to pass the response schema in as a guide, not manually validating it (I will have a look)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3
commit 0520423
Author: freepilot-bot [email protected]
Date: Fri Jun 20 08:00:43 2025 +0000
View job on Freepilot: https://freepilot.albylabs.com/jobs/19