Display marker with cutout if symbol is not defined or blank #6791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the test names might be flipped? But otherwise great, this looks like a good solution to me. |
Good catch. |
seadowg
approved these changes
Jul 7, 2025
seadowg
added a commit
that referenced
this pull request
Jul 8, 2025
Display marker with cutout if symbol is not defined or blank
|
Tested with Success! Verified on a device with Android 10 Verified cases:
|
|
Tested with success Verified on device with Android 15 |
This was referenced Jul 11, 2025
This was referenced Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6779
Why is this the best possible solution? Were any other approaches considered?
It simply makes more sense to always display markers with a cutout whenever a symbol is not defined properly.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It simply fixes the bug, with minimal risk of affecting other functionality.
Do we need any specific form for testing your changes? If so, please attach one.
I used this one:
form.zip
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest