Switch to ML Kit as default scanner #6875
Merged
+12
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzesiek2010
requested changes
Sep 5, 2025
| <!-- Option provided in the Experimental settings to opt in/out of the newer ML Kit based barcode scanner --> | ||
| <string name="use_mlkit_for_barcode_scanning">Use ML Kit for barcode scanning</string> | ||
| <string name="mlkit_is_always_used_for_scanning_project_qr_codes">ML Kit is always used for scanning project QR codes</string> | ||
| <!-- Option provided in the Experimental settings to rever to the old Zxing based barcode scanner --> |
There was a problem hiding this comment.
rever -> revert and also x i Zxing should be capitalized ZXing.
grzesiek2010
approved these changes
Sep 5, 2025
|
Tested with success Verified on device with Android 10, 16 Verified cases:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the experimental ML Kit opt-in so that it'll always be used in release builds. Instead, I've added a switch in "Developer tools" that allows us to switch back to ZXing scanning so that we can test that without needing a device that doesn't have Play Services.
@getodk/testers it's probably worth doing a pass of project QR and form entry barcode scanning with "Revert to older barcode scanner" enabled as we've not really been using the ZXing barcode scanner since all the recent changes were made.