Make delete trigger translatable #6881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lognaturel
reviewed
Sep 10, 2025
| return """ | ||
| $message:<br/> | ||
| <br/> | ||
| • $formDefinitions<br/> |
There was a problem hiding this comment.
I'm curious to see how this will look with a RTL language! I think if it's not great we can file it as a low-priority issue.
lognaturel
approved these changes
Sep 10, 2025
|
Tested with Success! Verified on Android 10 Verified cases:
|
|
Tested with Success! Verified on Android 16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this the best possible solution? Were any other approaches considered?
The advantage of implementing the delete dialog message this way is that the "delete" trigger can be translated for users that wouldn't be able to easily type it with their soft keyboard. Additionally, I've changed extracted the HTML parts of the message to our view code so that translators don't have to deal with it.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Do we need any specific form for testing your changes? If so, please attach one.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest