Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Go 1.22#295

Merged
markya0616 merged 2 commits intomasterfrom
go-1.22
May 31, 2024
Merged

Go 1.22#295
markya0616 merged 2 commits intomasterfrom
go-1.22

Conversation

@markya0616
Copy link
Contributor

Before submitting a pull request, please make sure the following is done:

Checklist

  • Fork the repository and create your new branch from master.
  • Please mention the name of community in Pull Request title.
  • Git Commit Messages
    • Use the present tense (Also in Pull Request title): "Add feature" not "Added feature"
    • Use the imperative mood (Also in Pull Request title): "Move cursor to..." not "Moves cursor to..."
    • Use rebase to squash/fixup dummy/unnecessary commits into only one commit.

@markya0616 markya0616 requested a review from cychuang0924 as a code owner May 30, 2024 08:43
@codecov
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.96%. Comparing base (a7d6ff6) to head (5cdb3c4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
- Coverage   76.78%   75.96%   -0.82%     
==========================================
  Files         146      152       +6     
  Lines       11357    11489     +132     
==========================================
+ Hits         8720     8728       +8     
- Misses       1872     2000     +128     
+ Partials      765      761       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alanchchen alanchchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@markya0616 markya0616 merged commit c36bd58 into master May 31, 2024
@markya0616 markya0616 deleted the go-1.22 branch May 31, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants