Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add curve type, slip10 type, and pubKey compression #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
markya0616 merged 6 commits into from
Nov 22, 2024
Merged

add curve type, slip10 type, and pubKey compression #297

markya0616 merged 6 commits into from
Nov 22, 2024

Conversation

@cychuang0924
Copy link
Contributor

@cychuang0924 cychuang0924 commented Nov 21, 2024

Before submitting a pull request, please make sure the following is done:

Checklist

  • Fork the repository and create your new branch from master.
  • Please mention the name of community in Pull Request title.
  • Git Commit Messages
    • Use the present tense (Also in Pull Request title): "Add feature" not "Added feature"
    • Use the imperative mood (Also in Pull Request title): "Move cursor to..." not "Moves cursor to..."
    • Use rebase to squash/fixup dummy/unnecessary commits into only one commit.

unaeat
unaeat previously approved these changes Nov 22, 2024
View reviewed changes
@unaeat unaeat force-pushed the addCurveType branch 3 times, most recently from c3b73d4 to 121ae33 Compare November 22, 2024 04:27
@unaeat unaeat force-pushed the addCurveType branch 4 times, most recently from f922eef to 014bd50 Compare November 22, 2024 05:03
@codecov
Copy link

codecov bot commented Nov 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 46.51163% with 23 lines in your changes missing coverage. Please review.

Project coverage is 75.87%. Comparing base (5cdb3c4) to head (6273604).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
crypto/elliptic/elliptic_curve.go 53.12% 14 Missing and 1 partial ⚠️
crypto/elliptic/ed25519.go 27.27% 6 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #297      +/-   ##
==========================================
- Coverage   75.96%   75.87%   -0.10%     
==========================================
  Files         152      152              
  Lines       11489    11532      +43     
==========================================
+ Hits         8728     8750      +22     
- Misses       2000     2019      +19     
- Partials      761      763       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

markya0616
markya0616 approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@markya0616 markya0616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markya0616 markya0616 merged commit c70f57c into master Nov 22, 2024
2 of 4 checks passed
@markya0616 markya0616 deleted the addCurveType branch November 22, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markya0616 markya0616 markya0616 approved these changes

@unaeat unaeat unaeat approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cychuang0924 @markya0616 @unaeat