Fix edwards cruve CompressedPublicKey #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cychuang0924
previously approved these changes
Nov 28, 2024
|
|
||
| func (ed *ed25519) CompressedPublicKey(secret *big.Int, method string) []byte { | ||
| if method == BIP32ED25519 { | ||
| x, y := edwards.Edwards().ScalarBaseMult(secret.Bytes()[:32]) |
Contributor
There was a problem hiding this comment.
BIP32ED25519 的原本是 bip32
幫我換成 BIP32ED25519 謝謝
90f81ec to
526bdd9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #299 +/- ##
==========================================
+ Coverage 75.92% 75.95% +0.03%
==========================================
Files 152 152
Lines 11532 11530 -2
==========================================
+ Hits 8756 8758 +2
+ Misses 2016 2012 -4
Partials 760 760 ☔ View full report in Codecov by Sentry. |
cychuang0924
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please make sure the following is done:
Checklist
master.