feat: cron based update scheduling #812

cabaucom376 · 2025-10-30T11:47:09Z

Replace the interval-based auto-update system entirely with a cron-based scheduler that supports:

Global cron schedules
Project-level cron overrides
Service-level boolean opt-in/out via com.ofkm.arcane.updater label
Human-readable cron descriptions in the UI with i18n support
Backend validation of cron expressions

closes #491

Disclaimer Greptiles Reviews uses AI, make sure to check over its work

Greptile Overview

Updated On: 2025-11-03 13:27:39 UTC

Greptile Summary

This PR successfully replaces the interval-based auto-update system with a comprehensive cron-based scheduler that addresses issue #491.

Key Changes

Global cron schedules: New autoUpdateCron setting replaces the old interval-based system, supporting standard 5-field cron expressions validated by the robfig/cron library
Project-level overrides: Projects can now set their own auto_update (nullable boolean) and auto_update_cron (nullable string) to override global settings, providing fine-grained control
Service-level opt-in/out: The com.ofkm.arcane.updater label is automatically injected into containers based on project settings, allowing per-service control
Immediate mode: Empty/null cron expressions trigger immediate updates (checks every 5 minutes when updates are detected)
UI improvements: New collapsible cron schedule component with intuitive presets (immediate, daily, weekdays, weekends, every N hours) and custom input with i18n support
Backend validation: Cron expressions are validated server-side using the robfig/cron parser before being saved, preventing invalid expressions

Implementation Quality

The implementation is well-structured with proper separation of concerns:

Validation is centralized in a reusable utility (cron_util.go)
The three-level hierarchy (global → project → service) is cleanly implemented
Database migrations properly handle the schema changes with nullable columns
The UI provides an excellent user experience with presets and custom input
Backward compatibility is maintained through migrations

Confidence Score: 5/5

This PR is safe to merge - the implementation is solid with proper validation, migrations, and comprehensive testing coverage
Score reflects excellent implementation quality with proper validation using a well-established library (robfig/cron), comprehensive migrations, clean architecture with three-level hierarchy (global/project/service), and good UI/UX. The previous comment about step value validation is incorrect - the robfig/cron library properly validates all cron expressions including step values. The feature is well-tested and maintains backward compatibility.
No files require special attention - all changes are well-implemented

Important Files Changed

File Analysis

Filename	Score	Overview
backend/internal/utils/cron/cron_util.go	5/5	New cron validation utility using robfig/cron library parser - properly validates all cron expressions including step values
backend/internal/job/auto_update_job.go	5/5	Replaced interval-based scheduling with cron-based scheduling, supports immediate mode (empty cron) and scheduled mode with proper job registration
backend/internal/services/settings_service.go	5/5	Added cron validation for `autoUpdateCron` setting at line 320-323, triggers reschedule callback on change
backend/internal/services/project_service.go	5/5	Added cron validation for project-level `autoUpdateCron` at line 791-794, passes project settings to LoadComposeProject
backend/internal/utils/projects/load.go	5/5	Added UpdaterLabel constant and label injection logic at lines 110-114 to set `com.ofkm.arcane.updater` based on project AutoUpdate setting
frontend/src/lib/components/cron-schedule-select.svelte	5/5	New reusable cron schedule component with presets (immediate, daily, weekdays, weekends, every N hours) and custom input support
frontend/src/routes/projects/components/ProjectSettingsPanel.svelte	5/5	New project settings panel with global/project toggle for auto-update, integrates cron schedule selector with proper state management

backend/internal/api/project_settings_handler.go

greptile-apps

_{33 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

backend/internal/utils/cron/cron_util.go

kmendell

I'm leaving for a trip in a few days, but few things I noticed so far.

The cron logic in the front and backend is not maintainable , there are libraries out there that can parse cron gocron it self may be able to as well.

Some of the friend logic like normalizing empty inputs can most like be solved by the backed by adding omitempty to. The JSON tags.

I'll try to take a look tomorrow if I have time, but it may be little bit before I can fully review everything.

cabaucom376 · 2025-10-31T10:26:34Z

I tried scouring for a good parsing package but everything seems un-maintained or unused so didn't feel confident choosing anything.

kmendell · 2025-10-31T16:12:56Z

@cabaucom376 I made some changes, i use libraries to parse the cron stuff, and teh frontend just had its use a zod schema instead. I also updated the styling to use the existsing styling ofr teh select component vs making a new component for this i though it looked clunky.

Ill try to look more later.

cabaucom376 · 2025-10-31T16:20:37Z

Cool, just checked it out. Only thing I'm noticing is that you cannot select immediate and null out the cron expression.

cabaucom376 · 2025-10-31T16:24:43Z

I also did really enjoy the human readable part of it, but if you think its too much thats okay.

kmendell · 2025-10-31T18:27:02Z

The Human Readable part? its still there just not for custom, If we do a human readbale format we get rid of the presets and somehow make universal logic to detect it which is just hard cause id rather not have that done on the fly it could make thinsg feel slow or clunky.

global cron expression can not be null. It has nothing to inherit from.

frontend/src/routes/settings/docker/+page.svelte

kmendell · 2025-11-03T00:12:22Z

frontend/src/routes/settings/docker/+page.svelte

 	$effect(() => {
 		if (cronScheduleMode !== 'custom') {
-			$formInputs.autoUpdateCron.value = cronScheduleMode;
+			$formInputs.autoUpdateCron.value = cronScheduleMode === null ? '' : cronScheduleMode;


I dont think this check is needed, 1. im pretty sure it gets set to null anyways and before i chnaged it to hide the text box, it did get set to null. 2. The logic is just messy and not how any of the rest of the data is sent, theres a much easier way to handle this, i just dont have the time to do it right now.

greptile-apps

_{35 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

kmendell · 2025-11-07T17:54:51Z

backend/internal/api/settings_handler.go

-		c.JSON(http.StatusInternalServerError, gin.H{
+		c.JSON(http.StatusBadRequest, gin.H{
 			"success": false,
-			"data":    dto.MessageDto{Message: "Failed to update settings"},


This should be the data field as the frontend services apiserver this.handleReponse will grab from the data field

kmendell · 2025-11-07T17:58:11Z

tests/spec/project.spec.ts

I think adding some e2e test for setting the settings of a project will be useful, that way if functionaltiy breaks we will know.

kmendell · 2025-11-07T17:58:57Z

frontend/src/routes/settings/navigation/+page.svelte

 			.updateSettings(data)
 			.then(() => toast.success(m.navigation_settings_saved()))
-			.catch((error) => {
+			.catch((error: any) => {


See my comment about the data field above, for all of this : any types. This should not be needed since it was all working with the "data" field.

kmendell · 2025-11-07T17:59:44Z

frontend/src/lib/services/project-service.ts

-			composeContent,
-			envContent
-		};
+		const payload: any = {};


This logic is overkill, we should aollow the same pattern as before, the backend should just send empty values if its not set.

cabaucom376 added 5 commits October 29, 2025 20:44

concept

dd872a8

projects

9183c30

Merge branch 'main' into cron-updating

04c0bc5

tweaks

a9ab237

ui

566add8

kmendell reviewed Oct 30, 2025

View reviewed changes

backend/internal/api/project_settings_handler.go Outdated Show resolved Hide resolved

cabaucom376 added 18 commits October 30, 2025 16:15

consolidate

77a8e4a

lint

65ccd8c

Merge branch 'main' into cron-updating

59d8d58

sql

67da456

more

e360340

sql 2

aaedf60

more

bc63072

not null

91001f2

tests

cb6224a

simplify

f93a272

minor

d30431e

style

18ff5a8

validation

84b415c

global toast

6371039

less

666b6ad

project state

5ab30e4

lint

5e01ccd

style

67bcf9e

cabaucom376 marked this pull request as ready for review October 30, 2025 23:10

cabaucom376 requested a review from a team as a code owner October 30, 2025 23:10

greptile-apps bot reviewed Oct 30, 2025

View reviewed changes

backend/internal/utils/cron/cron_util.go Outdated Show resolved Hide resolved

cabaucom376 added 2 commits October 30, 2025 19:22

feedback

e0ba454

Merge branch 'main' into cron-updating

2355e34

cabaucom376 requested a review from kmendell October 30, 2025 23:26

kmendell reviewed Oct 31, 2025

View reviewed changes

kmendell added 2 commits October 31, 2025 10:44

libraries

e95f5fd

use exsisting styling and better logic

baf1921

format

e3ac06d

null for imediate

3c4b3e1

cabaucom376 added 2 commits October 31, 2025 17:45

minor consolidation

a8f6cc6

patch nullability

ab873d3

global cron expression can not be null. It has nothing to inherit from.

kmendell reviewed Nov 3, 2025

View reviewed changes

frontend/src/routes/settings/docker/+page.svelte Show resolved Hide resolved

kmendell reviewed Nov 3, 2025

View reviewed changes

cabaucom376 added 2 commits November 3, 2025 08:21

component

f0e8e6e

Merge branch 'main' into cron-updating

8a7e210

cabaucom376 closed this Nov 3, 2025

cabaucom376 deleted the cron-updating branch November 3, 2025 13:23

cabaucom376 restored the cron-updating branch November 3, 2025 13:24

cabaucom376 reopened this Nov 3, 2025

greptile-apps bot reviewed Nov 3, 2025

View reviewed changes

Merge branch 'main' into cron-updating

b0f5eef

kmendell requested a review from a team as a code owner November 6, 2025 17:06

kmendell requested changes Nov 7, 2025

View reviewed changes

Uh oh!

feat: cron based update scheduling #812

Are you sure you want to change the base?

feat: cron based update scheduling #812

Uh oh!

Conversation

cabaucom376 commented Oct 30, 2025 • edited by greptile-apps bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Overview

Greptile Summary

Key Changes

Implementation Quality

Confidence Score: 5/5

Important Files Changed

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kmendell left a comment

Choose a reason for hiding this comment

Uh oh!

cabaucom376 commented Oct 31, 2025

Uh oh!

kmendell commented Oct 31, 2025

Uh oh!

cabaucom376 commented Oct 31, 2025

Uh oh!

cabaucom376 commented Oct 31, 2025

Uh oh!

kmendell commented Oct 31, 2025

Uh oh!

Uh oh!

kmendell Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

kmendell Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

kmendell Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

kmendell Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

kmendell Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cabaucom376 commented Oct 30, 2025 •

edited by greptile-apps bot

Loading