includes/Intelligence/Services/Models/OpenAIGPTThreeDotFiveTurbo.php (1)

108-133: Make the system prompt configurable instead of hardcoding e-commerce specific instructions.

The hardcoded system prompt is overly specific to e-commerce product descriptions and limits the model's flexibility for other use cases. Consider making it configurable through settings or accepting it as a parameter.

Apply this diff to make the system prompt configurable:

         if ( isset( $args['json_format'] ) ) {
+            $default_system_prompt = 'You are an AI assistant. Always return the response in strict JSON format without any markdown or special characters.';
+            $system_prompt = apply_filters( 'dokan_ai_openai_system_prompt', $default_system_prompt, $prompt, $args );
+            
             array_unshift(
                 $messages, [
                     'role' => 'system',
-                    'content' => 'You are an AI assistant specializing in WooCommerce and e-commerce product.
-                    Your task is to generate SEO-optimized content that helps increase sales and search rankings.
-                    Always return the response in strict JSON format without any markdown or special characters.
-                    Format the response as follows:
-                    {
-                      "title": "<Compelling product title optimized for SEO>",
-                      "short_description": "<A concise, keyword-rich summary (minimum 80-150 words) that attracts buyers and improves search engine visibility>",
-                      "long_description": "<A detailed, engaging product long description including features, benefits, use cases, and persuasive copywriting techniques>"
-                    }
-
-                    Guidelines:
-                    — Output language should be the same as the input language strictly matching the prompt.
-                    — Using <p></p> tags for paragraphs instead of newlines.
-                    — Do not use Markdown formatting (** or `#` or `>` characters).
-                    — Do not include backticks (```json or ```) or any non-JSON syntax.
-                    — Do not add extra commentary or explanations—only return the JSON object.
-                    — Ensure readability with short sentences, bullet points, and clear formatting.
-                    — Highlight key features (if need), unique selling points, and benefits.
-                    — Output should be a valid JSON object with the keys: title, short_description, long_description.',
+                    'content' => $system_prompt,
                 ],
             );
         }

includes/Intelligence/Services/Models/GeminiTwoDotFiveFlashLite.php (2)

69-93: Extract duplicated system prompt to a shared location.

The hardcoded system prompt for JSON format is duplicated across multiple model implementations (OpenAI and Gemini). This violates the DRY principle and makes maintenance difficult.

Consider creating a shared trait or helper class for common AI prompts:

// In a new file: includes/Intelligence/Services/Traits/AIPromptsTrait.php
trait AIPromptsTrait {
    protected function getProductDescriptionSystemPrompt(): string {
        return apply_filters( 'dokan_ai_product_description_system_prompt', 
            'You are an AI assistant specializing in WooCommerce and e-commerce product...'
        );
    }
}

Then use it in your model classes:

+use WeDevs\Dokan\Intelligence\Services\Traits\AIPromptsTrait;
+
 class GeminiTwoDotFiveFlashLite extends Model implements AITextGenerationInterface {
+    use AIPromptsTrait;
+    
     // ... other code ...
     
     protected function get_payload( string $prompt, array $args = [] ): array {
         if ( isset( $args['json_format'] ) ) {
-            $pre_prompt = 'You are an AI assistant specializing in WooCommerce and e-commerce product...';
+            $pre_prompt = $this->getProductDescriptionSystemPrompt();
             $prompt = $pre_prompt . PHP_EOL . $prompt;
         }

---

135-137: Remove unnecessary quote stripping logic.

Similar to the OpenAI model, this quote stripping logic could corrupt valid JSON strings that legitimately contain quotes.

Apply this diff:

-        // if response type of string
-        if ( gettype( $response ) === 'string' ) {
-            $response = preg_replace( '/^"(.*)"$/', '$1', $response );
-        }

includes/Intelligence/Services/AIImageGenerationInterface.php (1)

5-15: Consider improving type safety and error handling guidance.

The interface design is clean, but there are opportunities for improvement:

1. The mixed return type is quite broad - consider using a more specific type or union type to better define expected return values
2. No guidance on error handling - consider documenting expected exceptions or error return patterns
3. The $prompt parameter lacks validation constraints (e.g., non-empty string requirements)

Consider this more specific approach:

interface AIImageGenerationInterface {
    /**
     * Process the image prompt and return the generated image.
     *
     * @param string $prompt The input prompt for the AI model (must not be empty).
     * @param array $args Optional additional data.
-    * @return mixed The generated image from the AI model.
+    * @return array|string The generated image data (URL, base64, or structured response).
+    * @throws \InvalidArgumentException When prompt is empty or invalid.
+    * @throws \RuntimeException When image generation fails.
     */
-   public function process_image( string $prompt, array $args = [] );
+   public function process_image( string $prompt, array $args = [] ): array|string;
}

includes/Intelligence/Services/AITextGenerationInterface.php (1)

5-15: Apply consistent improvements with AIImageGenerationInterface.

This interface has identical design considerations as AIImageGenerationInterface. For consistency:

1. Consider the same type safety improvements (more specific return types)
2. Add similar error handling documentation
3. Include parameter validation guidance

Additionally, given the structural similarity between text and image generation interfaces, consider whether a base interface would be beneficial:

+interface AIGenerationInterface {
+    /**
+     * Process the prompt and return the generated content.
+     *
+     * @param string $prompt The input prompt for the AI model.
+     * @param array $args Optional additional data.
+     * @return mixed The generated content from the AI model.
+     */
+    public function process( string $prompt, array $args = [] );
+}
+
-interface AITextGenerationInterface {
+interface AITextGenerationInterface extends AIGenerationInterface {
    /**
     * Process the text prompt and return the generated response.
     */
-   public function process_text( string $prompt, array $args = [] );
+   public function process_text( string $prompt, array $args = [] ): string;
}

includes/Intelligence/Services/Models/OpenAIChatGPTFourO.php (2)

1-3: Add declare(strict_types=1); and a file-level docblock

All new model files omit strict_types. Enabling strict typing avoids silent coercions and aligns with modern PHP best practices.
Likewise, a short docblock (author, purpose) helps future maintainers.

 <?php
+declare(strict_types=1);
+
+/**
+ * Model: OpenAI ChatGPT-4o
+ *
+ * @package dokan-lite
+ */

---

5-12: Consider making lightweight metadata classes final

These classes only provide constants; subclassing them brings no benefit and can introduce accidental overrides. Marking them final signals intent and allows small opcache optimisations.

-class OpenAIChatGPTFourO extends OpenAIGPTThreeDotFiveTurbo {
+final class OpenAIChatGPTFourO extends OpenAIGPTThreeDotFiveTurbo {

includes/Intelligence/Services/Models/OpenAIGPTFourOMini.php (2)

1-3: Apply strict types & docblock (same as other model files)

---

5-6: Mark as final to prevent unintended inheritance

Same rationale as the previous class.

-class OpenAIGPTFourOMini extends OpenAIGPTThreeDotFiveTurbo {
+final class OpenAIGPTFourOMini extends OpenAIGPTThreeDotFiveTurbo {

includes/Intelligence/Services/Models/OpenAIGPTFourTurbo.php (2)

1-3: Add declare(strict_types=1); & header docblock

---

5-6: Prefer final keyword for constant-only classes

-class OpenAIGPTFourTurbo extends OpenAIGPTThreeDotFiveTurbo {
+final class OpenAIGPTFourTurbo extends OpenAIGPTThreeDotFiveTurbo {

includes/Intelligence/Services/Providers/OpenAI.php (3)

1-3: Enable strict types & add file docblock

Consistent with other service classes.

 <?php
+declare(strict_types=1);
+
+/**
+ * Provider: OpenAI
+ *
+ * @package dokan-lite
+ */

---

30-32: Default model choice – is gpt-3.5-turbo still intended?

With several GPT-4* variants bundled, shipping the 3.5 model as default may surprise users expecting the newest capabilities.
Consider elevating the default to gpt-4-turbo (once verified) or exposing a setting in the UI.

---

34-36: Hard-coded URL – add constant or config

If the OpenAI dashboard URL ever changes, having it duplicated in code is brittle.
Suggest extracting to a class constant or configuration option.

-    public function get_api_key_url(): string {
-        return 'https://platform.openai.com/api-keys';
-    }
+    public function get_api_key_url(): string {
+        return self::API_KEY_URL;
+    }
+
+    private const API_KEY_URL = 'https://platform.openai.com/api-keys';

includes/Intelligence/Services/Models/GeminiTwoDotFiveFlash.php (4)

5-6: Remove unused Model import

use WeDevs\Dokan\Intelligence\Services\Model; is never referenced, violating WPCS UnusedUse rule.

-use WeDevs\Dokan\Intelligence\Services\Model;

---

1-3: Missing declare(strict_types=1); and docblock

Same recommendation as for the OpenAI models.

---

8-9: Make the class final

Lightweight metadata container – inheritance not required.

-class GeminiTwoDotFiveFlash extends GeminiTwoDotFiveFlashLite implements AITextGenerationInterface {
+final class GeminiTwoDotFiveFlash extends GeminiTwoDotFiveFlashLite implements AITextGenerationInterface {

---

10-30: Mixed tabs and spaces

Lines 10-30 use tabs, earlier lines use spaces. This will be flagged by PHPCS Generic.WhiteSpace.DisallowTabIndent. Convert to spaces for consistency.

includes/Intelligence/Services/Models/GeminiTwoDotFivePro.php (1)

6-6: Remove unused import

The Model class is imported but not used in this file.

-use WeDevs\Dokan\Intelligence\Services\Model;

includes/Intelligence/Services/AIProviderInterface.php (1)

69-69: Fix documentation to match the generic parameter

The comment mentions "text models" but the method accepts any model type as a parameter.

-     * @return bool True if text models are supported, false otherwise.
+     * @return bool True if models of the specified type are supported, false otherwise.

includes/Intelligence/Services/Provider.php (1)

52-53: Clean up commented code.

Remove the commented array_find code since it's not available in older PHP versions and the current implementation using array_filter works correctly.

-        // $model = array_find( $models, fn( $model, $key ) => $model->get_id() === $model_id );
-        // Using array_filter to find the model by ID
+        // Using array_filter to find the model by ID

includes/Intelligence/Manager.php (1)

149-166: Consider adding PHPDoc for the switch cases.

The get_type_prefix method would benefit from documenting why certain types have prefixes while text doesn't.

     /**
      * Get the type prefix for the given generation type.
      *
+     * Text generation uses no prefix for backward compatibility,
+     * while other types use prefixes to namespace their settings.
+     *
      * @param string $type The type of generation (e.g., 'text', 'image', 'video').
      *
      * @return string The prefix for the type.
      */
     public function get_type_prefix( string $type ): string {

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

includes/Intelligence/REST/AIRequestController.php (1)

95-105: Validate capability before dynamic dispatch (extend previous feedback)

You added the method_exists check (good), but also verify the model actually supports the requested type to fail fast and avoid misleading 400s.

-            if ( ! method_exists( $model, $process_call ) ) {
+            if ( ( method_exists( $model, 'supports' ) && ! $model->supports( $type ) ) || ! method_exists( $model, $process_call ) ) {
                 throw new Exception(
                     // translators: %s: type of generation.
                     sprintf( esc_html__( 'Model does not support %s generation.', 'dokan-lite' ), $type ),
                     400
                 );
             }

includes/Intelligence/Services/Model.php (1)

113-114: Fix docblock: return value is URL, not API key

-     * Retrieves the API url required.
-     *
-     * @return string The API key.
+     * Retrieves the API URL for the request.
+     *
+     * @return string The endpoint URL.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro