includes/Admin/Settings/Elements/Fields/RadioBox.php (1)

5-9: Fix class documentation inconsistency.

The class docblock refers to "RadioButton Field" but the class name is RadioBox. Update the documentation to match the class name.

-/**
- * RadioButton Field.
- *
- * Custom field that provides radio options as button.
- */
+/**
+ * RadioBox Field.
+ *
+ * Custom field that provides radio options as buttons.
+ */

includes/Admin/Settings/Elements/Fields/Tel.php (2)

5-7: Fix incorrect class documentation.

The class docblock incorrectly refers to "Test Field" instead of "Tel Field" or "Telephone Field".

-/**
- * Test Field.
- */
+/**
+ * Telephone Field.
+ *
+ * Input field for telephone numbers.
+ */

---

24-26: Consider enhancing telephone number validation.

The current validation only checks if data is set, which is quite basic for a telephone field. Consider implementing more specific validation for telephone number formats.

For example, you could add basic format validation:

 public function data_validation( $data ): bool {
-    return isset( $data );
+    if ( ! isset( $data ) || empty( $data ) ) {
+        return false;
+    }
+    
+    // Basic phone number validation (digits, spaces, hyphens, parentheses, plus)
+    return preg_match( '/^[\d\s\-\(\)\+]+$/', $data );
 }

includes/Admin/Settings/Elements/Fields/Password.php (2)

5-7: Fix incorrect class comment.

The comment says "Test Field" but this is actually a Password field class.

-/**
- * Test Field.
- */
+/**
+ * Password Field.
+ */

---

24-26: Consider enhancing password field validation.

The current validation only checks if data is set, which may be too permissive for password fields. Consider adding password-specific validation such as minimum length requirements, complexity rules, or other security constraints based on your application's password policy.

 public function data_validation( $data ): bool {
-    return isset( $data );
+    // Add password-specific validation if needed
+    // e.g., minimum length, complexity requirements
+    return isset( $data ) && is_string( $data ) && strlen( trim( $data ) ) > 0;
 }

includes/Admin/Settings/Elements/Section.php (1)

1-53: LGTM: Consistent implementation with minor documentation improvements needed.

The Section class follows the established pattern for settings elements. The implementation is consistent with other container-type elements like Tab, SubPage, and SubSection.

Minor suggestions:

• Consider adding more descriptive class documentation explaining the purpose of a "section" element
• The sanitize_element method return type annotation shows array|string but only returns the result of wp_unslash() - consider clarifying the expected return type

 /**
- * Section Class.
+ * Section settings element class for grouping related settings.
+ *
+ * Represents a container element that groups related settings fields,
+ * typically used to organize settings within a tab or page.
  */
 class Section extends SettingsElement {

includes/Admin/Settings/Elements/Tab.php (1)

1-52: LGTM: Consistent implementation with documentation enhancement opportunity.

The Tab class properly follows the established pattern for settings elements and is consistent with other container-type elements.

Consider enhancing the class documentation to better explain the role of tab elements in the settings hierarchy:

 /**
- * Tab Class.
+ * Tab settings element class for organizing settings into tabbed interfaces.
+ *
+ * Represents a tab container that groups related settings, typically used
+ * to organize settings into separate tabs within a settings page.
  */
 class Tab extends SettingsElement {

includes/Admin/Dashboard/Pages/Settings.php (1)

38-47: Consider using the position parameter.

The menu() method accepts a $position parameter but hardcodes the position to 5. Consider using the parameter or remove it if not needed.

 public function menu( string $capability, string $position ): array {
     return [
         'page_title' => __( 'Admin Settings', 'dokan-lite' ),
         'menu_title' => __( 'Settings', 'dokan-lite' ),
         'route'      => $this->get_id(),
         'capability' => $capability,
-        'position'   => 5,
+        'position'   => (int) $position,
         'hidden'     => false,
     ];
 }

includes/Admin/Settings/Pages/PageInterface.php (1)

10-59: Update @SInCE placeholder tags before release.

The interface design is well-structured with clear method contracts. However, all @since tags currently use the placeholder DOKAN_SINCE which should be replaced with the actual version number before release.

Replace all instances of DOKAN_SINCE with the actual version:

-     * @since DOKAN_SINCE
+     * @since 3.x.x

includes/Admin/Settings/Elements/Fields/Switcher.php (1)

63-70: Add missing PHPDoc comment for consistency.

The set_disable_state method is missing its PHPDoc comment block, which breaks consistency with other methods in the class.

Add the missing PHPDoc comment:

+    /**
+     * Set disable state.
+     *
+     * @param string $label Disable state label.
+     * @param string $value Disable state value.
+     *
+     * @return Switcher
+     */
     public function set_disable_state( string $label, string $value ): Switcher {

includes/Admin/Settings/Elements/SubPage.php (2)

7-9: Fix incorrect class name in docblock.

The docblock comment refers to "Page Class" but this is the SubPage class.

- * Page Class.
+ * SubPage Class.

---

35-35: Fix inconsistent return type documentation.

The return type annotation shows array|string but the actual return type and usage pattern (consistent with other elements) suggests it should return the same type as input.

-     * @return array|string
+     * @return mixed

includes/Admin/Settings/Elements/Fields/Select.php (1)

8-8: Consider inheritance hierarchy - Select extending Checkbox may be confusing.

The inheritance choice is unusual since Select fields typically handle single values (non-array) while Checkbox fields handle multiple values (array data). This creates a semantic inconsistency in the class hierarchy.

Consider making Select extend Text or Field directly, or create a common base class for option-based fields:

-class Select extends Checkbox {
+class Select extends Text {

includes/Admin/Settings/Settings.php (3)

80-82: Remove unused variable flagged by static analysis.

The $index variable in the foreach loop is unused and should be removed.

-foreach ( $pages as $index => $page ) {
+foreach ( $pages as $page ) {
	$mapped_pages[] = $page->populate();
}

---

30-31: Document the InvalidArgumentException in method signature.

The method throws \InvalidArgumentException but this isn't documented in the @throws annotation, which is inconsistent with the docblock style used elsewhere.

/**
 * Get all pages.
 *
 * @since DOKAN_SINCE
 *
 * @return array< AbstractPage >
 *
+ * @throws \InvalidArgumentException If any page is not an instance of AbstractPage.
- * @throws \InvalidArgumentException If the step is not an instance of AbstractPage.
 */

---

46-48: Improve filter validation robustness.

The current validation simply returns the original pages if the filtered result isn't an array. Consider logging this scenario or providing more explicit handling.

if ( ! is_array( $pages ) ) {
+	// Log unexpected filter result for debugging
+	error_log( 'dokan_admin_settings_pages filter returned non-array value' );
	return $this->pages;
}

includes/Admin/Settings/Elements/Fields/Commission/CategoryBasedCommission.php (1)

75-75: Consider dependency injection for Categories controller.

Creating a new Categories instance in the populate() method on every call could impact performance and makes testing more difficult.

Consider dependency injection or lazy loading:

+private $categories_controller;

+private function get_categories_controller(): Categories {
+	if ( ! $this->categories_controller ) {
+		$this->categories_controller = new Categories();
+	}
+	return $this->categories_controller;
+}

public function populate(): array {
-	$categories_controller     = new Categories();
+	$categories_controller     = $this->get_categories_controller();
	$data                      = parent::populate();

includes/Admin/Settings/Pages/AbstractPage.php (2)

25-37: Replace placeholder version tags with actual version.

The @since DOKAN_SINCE placeholder should be replaced with the actual version number.

-     * @since DOKAN_SINCE
+     * @since 3.x.x

---

88-88: Use a constant for the filter name to improve maintainability.

Hard-coded filter names make refactoring difficult and prone to typos.

Consider defining this as a class constant:

private const SETTINGS_PAGES_FILTER = 'dokan_admin_settings_pages';

Then use:

-        add_filter( 'dokan_admin_settings_pages', [ $this, 'enlist' ] );
+        add_filter( self::SETTINGS_PAGES_FILTER, [ $this, 'enlist' ] );

includes/Admin/Settings/Elements/Fields/Commission/CombineInput.php (3)

24-31: Consider using appropriate numeric types for fee and percentage values.

Using string for numeric values like fees and percentages may lead to type confusion and calculation errors.

-    protected $additional_fee = '';
-    protected $admin_percentage = '';
+    protected float $additional_fee = 0.0;
+    protected float $admin_percentage = 0.0;

Update corresponding getter/setter methods accordingly.

---

119-119: Fix inconsistent indentation.

Line 119 uses tab indentation while the rest of the file uses spaces.

-	    return esc_html( $data );
+        return esc_html( $data );

---

76-76: Fix parameter naming inconsistency.

Parameter $percentage should match the property name $admin_percentage for clarity.

-     * @param string $percentage Percentage value.
+     * @param string $admin_percentage Percentage value.

-    public function set_admin_percentage( string $percentage ): CombineInput {
+    public function set_admin_percentage( string $admin_percentage ): CombineInput {

-        $this->admin_percentage = $percentage;
+        $this->admin_percentage = $admin_percentage;

includes/Admin/Settings/Elements/ElementFactory.php (1)

69-75: Simplify the return type annotation and consider implementation efficiency.

The return type annotation is very long and the implementation creates a Field object just to call get_input().

-     * @return Text|Number|Checkbox|Radio|Select|Tel|Password|RadioBox|Switcher|MultiCheck|Currency
+     * @return SettingsElement
      */
     public static function field( string $id, string $type = 'text' ): SettingsElement {
-        $field = new Field( $id, $type );
-
-        return $field->get_input();
+        return ( new Field( $id, $type ) )->get_input();
     }

includes/Admin/Settings/Elements/Fields/Text.php (1)

8-10: Fix documentation typo.

Class documentation has a typo: "Test Field" should be "Text Field".

 /**
- * Test Field.
+ * Text Field.
  */

includes/Admin/Settings/Elements/Fields/Number.php (3)

24-29: Fix PHPDoc format for consistency.

The PHPDoc is missing the property name in the annotation.

Apply this diff to fix the PHPDoc:

 /**
  * Maximum.
  *
- * @var float Maximum.
+ * @var float $maximum Maximum.
  */
 protected $maximum;

---

38-45: Fix PHPDoc return type to match nullable return.

 /**
  * Get minimum value.
  *
- * @return float
+ * @return float|null
  */
 public function get_minimum(): ?float {

---

82-89: Fix PHPDoc return type to match nullable return.

 /**
  * Get step value.
  *
- * @return float
+ * @return float|null
  */
 public function get_step(): ?float {

includes/REST/AdminSettingsController.php (1)

20-25: Replace version placeholder with actual version.

 /**
  * Register all routes.
  *
- * @since DOKAN_SINCE
+ * @since 3.8.0
  *
  * @return void
  */

includes/Admin/Settings/ElementTransformer.php (3)

3-6: Remove redundant namespace in use statement.

TransformerInterface is in the same namespace, so the full namespace is not needed.

 namespace WeDevs\Dokan\Admin\Settings;
 
-use WeDevs\Dokan\Admin\Settings\TransformerInterface;
+use TransformerInterface;
 use WeDevs\Dokan\Admin\Settings\Elements\ElementFactory;

Or simply remove the use statement and use TransformerInterface directly since it's in the same namespace.

---

8-18: Remove unused property.

The $settings property is declared but never used in the class.

 class ElementTransformer implements TransformerInterface {
     /**
      * @var array<string, array> $sections
      */
     protected array $sections = [];
     /**
      * @var array<string, array> $fields
      */
     protected array $fields = [];
-    protected $settings;

---

106-116: Consider logging when fallback types are used.

When unsupported field types fall back to 'text', it would be helpful to log this for debugging.

             default:
                 // Map some field types to their correct names
                 $type_mapping = [
                     'switcher' => 'switch',
                     'wpeditor' => 'text', // Fallback for unsupported types
                     'file' => 'text', // Fallback for unsupported types
                 ];
 
                 $mapped_type = $type_mapping[ $type ] ?? $type;
+                
+                // Log when using fallback types
+                if ( in_array( $type, [ 'wpeditor', 'file' ], true ) ) {
+                    // Consider adding logging here
+                    // do_action( 'dokan_admin_settings_unsupported_field_type', $type, $field_id );
+                }
+                
                 $element = ElementFactory::field( $field_id, $mapped_type );
                 break;

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

includes/Admin/Settings/Pages/GeneralPage.php (1)

96-96: Fix unused variable in foreach loop.

The variable $page_id is declared but never used within the loop. This creates unnecessary overhead and triggers static analysis warnings.

Apply this fix:

-		foreach ( $pages as $page_id => $page ) {
+		foreach ( $pages as $page ) {

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

src/stores/adminSettings/selectors.ts (1)

12-25: Consider simplifying boolean flag selectors.

The loading, saving, and needSaving selectors can be simplified by directly returning the state property without destructuring.

     getLoading( state: SettingsState ) {
-        const { loading } = state;
-        return loading;
+        return state.loading;
     },

     getSaving( state: SettingsState ) {
-        const { saving } = state;
-        return saving;
+        return state.saving;
     },

     getNeedSaving( state: SettingsState ) {
-        const { needSaving } = state;
-        return needSaving;
+        return state.needSaving;
     },

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

src/admin/dashboard/pages/settings/Elements/FiendGroup.tsx (1)

1-46: Fix the filename typo.

The filename has a typo: "FiendGroup.tsx" should be "FieldGroup.tsx". This affects imports in other files and could cause confusion.

Rename the file from FiendGroup.tsx to FieldGroup.tsx and update the import in SettingsParser.tsx:

-import FieldGroup from './FiendGroup';
+import FieldGroup from './FieldGroup';

src/admin/dashboard/pages/settings/Elements/Section.tsx (1)

1-1: Fix the import path for better organization.

Same issue as in Password component - importing from setup guide directory is incorrect.

src/admin/dashboard/pages/settings/Elements/FiendGroup.tsx (2)

1-1: Fix the import path for better organization.

Same import path issue as other components.

---

28-28: Add null check for element.children.

Same issue as in Section component - missing null check before mapping.

-{ element.children.map( ( child ) => {
+{ element.children?.map( ( child ) => {

src/admin/dashboard/pages/settings/Elements/SettingsParser.tsx (1)

1-1: Fix the import path for better organization.

Same import path issue as other components.

src/admin/dashboard/pages/settings/Elements/Fields/Password.tsx (2)

11-11: Add type annotation for the event parameter.

The event parameter lacks proper TypeScript typing, which reduces type safety.

-const handleValueChange = ( event ) => {
+const handleValueChange = ( event: React.ChangeEvent<HTMLInputElement> ) => {

---

33-33: Reconsider the autocomplete setting for password fields.

Using autoComplete="off" for password fields is generally not recommended as it prevents browsers from offering to save passwords, which reduces user experience.

-autoComplete="off"
+autoComplete="current-password"

src/admin/dashboard/pages/settings/Elements/SettingsParser.tsx (1)

53-53: Remove unnecessary Fragment.

The static analysis tool correctly identified an unnecessary Fragment that should be replaced with null.

-<></>,
+null,

src/admin/dashboard/pages/settings/index.tsx (3)

197-198: Fix text domain inconsistency.

The component uses 'dokan-driver' text domain instead of 'dokan-lite' which is used elsewhere in the same file.

-{ isSaving
-    ? __( 'Saving..', 'dokan-driver' )
-    : __( 'Save', 'dokan-driver' ) }
+{ isSaving
+    ? __( 'Saving..', 'dokan-lite' )
+    : __( 'Save', 'dokan-lite' ) }

---

133-138: Implement proper error handling and user feedback.

The TODOs indicate missing success and error feedback for the save operation. This creates poor user experience.

Do you want me to help implement proper toast notifications or alert messages for save operations?

.then( () => {
    setIsSaving( false );
-   // TODO: Say updated.
+   // Show success notification
+   dispatch( 'core/notices' ).createSuccessNotice(
+       __( 'Settings saved successfully!', 'dokan-lite' )
+   );
} )
.catch( ( err ) => {
    setIsSaving( false );
-   // TODO: Say Error.
+   // Show error notification
+   dispatch( 'core/notices' ).createErrorNotice(
+       __( 'Failed to save settings. Please try again.', 'dokan-lite' )
+   );
} );

---

84-109: Consider simplifying the complex conditional logic.

The nested conditional logic for determining elements is complex and could be refactored for better readability and maintainability.

Consider extracting this logic into a separate function:

const determineElements = useCallback(() => {
    if (loading) return [];
    
    if (!pages?.length && !tabs?.length) {
        return allSettings;
    }
    
    if (pages?.length && !tabs?.length && selectedPage) {
        return pages.find(child => child.id === selectedPage)?.children || [];
    }
    
    if (!pages?.length && tabs?.length && selectedTab) {
        return tabs.find(child => child.id === selectedTab)?.children || [];
    }
    
    if (pages?.length && tabs?.length && selectedPage && selectedTab) {
        return tabs.find(child => child.id === selectedTab)?.children || [];
    }
    
    return [];
}, [allSettings, pages, selectedPage, tabs, selectedTab, loading]);

useEffect(() => {
    setElements(determineElements());
}, [determineElements]);

src/admin/dashboard/pages/settings/Elements/Fields/FieldParser.tsx (1)

20-20: Address the TODO comment for custom field support.

The TODO indicates missing support for custom input fields and hooks. This could limit extensibility of the settings system.

Would you like me to help design an implementation for custom field support or create an issue to track this enhancement?

src/admin/dashboard/pages/settings/Elements/Fields/Tel.tsx (2)

30-30: Consider making the phone pattern more flexible for international numbers.

The current pattern [0-9]{3}-[0-9]{2}-[0-9]{3} is very restrictive and may not accommodate international phone number formats.

Consider using a more flexible pattern or making it configurable:

-                pattern="[0-9]{3}-[0-9]{2}-[0-9]{3}"
+                pattern={element.pattern || "[0-9+\\-\\s()]+"}

---

11-11: Add TypeScript type annotation for the event parameter.

The event parameter should have proper TypeScript typing for better type safety.

-    const handleValueChange = ( event ) => {
+    const handleValueChange = ( event: React.ChangeEvent<HTMLInputElement> ) => {

src/admin/dashboard/pages/settings/Elements/Fields/MultiCheck.tsx (1)

13-13: Add TypeScript type annotation for the values parameter.

The values parameter should have proper TypeScript typing.

-    const handleChange = ( values ) => {
+    const handleChange = ( values: string[] ) => {

src/admin/dashboard/pages/settings/Elements/Tab.tsx (2)

16-16: Make the onTabClick parameter type more specific.

The parameter name tabs is misleading - it should reflect that it receives a tab ID.

-    onTabClick: ( tabs ) => void;
+    onTabClick: ( tabId: string ) => void;

---

35-35: Use null instead of empty fragments for better performance.

Returning null is more semantically correct and slightly more performant than empty fragments for conditional rendering.

-                                return <></>;
+                                return null;

Also applies to: 51-51

src/admin/dashboard/pages/settings/Elements/Fields/Text.tsx (1)

11-11: Add TypeScript type annotation for the event parameter.

The event parameter should have proper TypeScript typing for better type safety.

-    const handleValueChange = ( event ) => {
+    const handleValueChange = ( event: React.ChangeEvent<HTMLInputElement> ) => {

src/admin/dashboard/pages/settings/Elements/Fields/Switcher.tsx (1)

9-18: Simplify the initial state determination logic.

The current logic for determining initialEnabled is verbose and repetitive. Consider refactoring for better readability and maintainability.

-    let initialEnabled = false;
-    if ( element.value === enableState?.value ) {
-        initialEnabled = true;
-    } else if ( element.value === disableState?.value ) {
-        initialEnabled = false;
-    } else if ( element.default === enableState?.value ) {
-        initialEnabled = true;
-    } else if ( element.default === disableState?.value ) {
-        initialEnabled = false;
-    }
+    const currentValue = element.value ?? element.default;
+    const initialEnabled = currentValue === enableState?.value;

src/admin/dashboard/pages/settings/Elements/SubSection.tsx (1)

19-19: Consider making the column span configurable.

The hardcoded col-span-4 class may limit layout flexibility. Consider making this configurable through props or element configuration.

-        <div className="col-span-4">
+        <div className={`col-span-${element.colSpan || 4}`}>

src/admin/dashboard/pages/settings/Elements/Fields/Commission/CombineInput.tsx (1)

11-11: Use consistent return pattern for conditional rendering.

This component returns null while other components in the codebase return <></> for the same condition. Consider maintaining consistency.

-        return null;
+        return <></>;

src/admin/dashboard/pages/settings/Elements/Menu.tsx (1)

3-5: Consider using a dedicated utility library for class name concatenation.

While the custom classNames function works, consider using a more robust library like clsx for better performance and features.

+import { clsx } from 'clsx';

-function classNames( ...classes ) {
-    return classes.filter( Boolean ).join( ' ' );
-}

Then replace classNames with clsx in the component.

src/admin/dashboard/pages/settings/Elements/Fields/Radio.tsx (1)

13-13: Add type annotation for better type safety

The newValue parameter should have a type annotation to ensure type safety.

-    const handleChange = ( newValue ) => {
+    const handleChange = ( newValue: string ) => {

src/admin/dashboard/pages/settings/Elements/Fields/RadioBox.tsx (1)

17-17: Add type annotations for event handlers

The handleChange and renderIcon functions need type annotations for better type safety.

-    const handleChange = ( newValue ) => {
+    const handleChange = ( newValue: string ) => {

And for renderIcon:

-    const renderIcon = ( value ) => {
+    const renderIcon = ( value: string ) => {

Also applies to: 26-26

src/admin/dashboard/pages/settings/Elements/Fields/Select.tsx (1)

13-13: Add type annotation for change handler

The onHandleChange function parameter should have a type annotation.

-    const onHandleChange = ( value ) => {
+    const onHandleChange = ( value: string ) => {

src/admin/dashboard/pages/settings/Elements/Fields/Commission/CategoryBasedCommission.tsx (1)

251-286: Replace custom isEqual with a library function

The custom deep equality implementation could be replaced with a well-tested library function for better reliability and maintainability.

Consider using lodash's isEqual:

import { isEqual } from 'lodash';

// Remove the custom implementation and use:
if (isEqual(newCommission?.items[key], newCommission?.all)) {
    delete newCommission?.items[key];
}

Or if you prefer not to add a dependency, at least simplify the implementation using modern JavaScript:

const isEqual = (a: any, b: any): boolean => {
    return JSON.stringify(a) === JSON.stringify(b);
};

Note: The JSON approach works for simple objects but has limitations with circular references and non-serializable values.