Hide empty Dokan Dashboard submenu in Dokan admin menu. #2835

Aunshon · 2025-08-11T04:08:16Z

All Submissions:

My code follow the WordPress' coding standards
My code satisfies feature requirements
My code is tested
My code passes the PHPCS tests
[] My code has proper inline documentation
I've included related pull request(s) (optional)
I've included developer documentation (optional)
I've added proper labels to this pull request

Closes

https://github.com/getdokan/dokan-pro/issues/4578

How to test the changes in this Pull Request:

Navigate to http://dokan-dev.test/wp-admin/admin.php?page=dokan-dashboard page you will find a black space there, this was solved in this pr.

Changelog entry

- **fix:** Hide empty Dokan Dashboard submenu in Dokan admin menu.

coderabbitai · 2025-08-11T04:08:23Z

Walkthrough

Adds a nested LESS rule to hide empty anchor tags within the Dokan admin submenu under the WordPress admin menu. No other selectors or logic are altered.

Changes

Cohort / File(s)	Change Summary
Admin menu CSS tweak `assets/src/less/global-admin.less`	Added nested rule: `#adminmenu #toplevel_page_dokan .wp-submenu a:empty { display: none; }`. Existing SVG background-size rule unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

QA approved, :+1: Dev Review Done, Upcoming Release

Suggested reviewers

shohag121
mrabbani

Poem

A nibble of CSS, a tidy little tune,
I hide empty links beneath the admin moon.
Dokan’s submenu hums, neat as a broom—
No ghostly anchors haunting the room.
Hop hop, ship soon! 🐇✨

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/dokan-dashboard-menu-blank-space

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

assets/src/less/global-admin.less (1)

321-329: Hide the entire list item for robustness (use :has).

Hiding only the anchor works in most cases, but hiding the parent

avoids any residual spacing/hover gaps and matches the file’s existing usage of :has.

Apply this diff:

-#adminmenu {
-    #toplevel_page_dokan {
-        .wp-submenu {
-            a:empty {
-                display: none;
-            }
-        }
-    }
-}
+#adminmenu {
+    #toplevel_page_dokan {
+        .wp-submenu {
+            // Hide empty submenu entries in Dokan Dashboard (see getdokan/dokan-pro#4578)
+            li:has(> a:empty) {
+                display: none;
+            }
+        }
+    }
+}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 93c4270 and f73c953.

📒 Files selected for processing (1)

assets/src/less/global-admin.less (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: e2e tests (2, 3)
GitHub Check: e2e tests (1, 3)
GitHub Check: e2e tests (3, 3)
GitHub Check: api tests (1, 1)

🔇 Additional comments (2)

assets/src/less/global-admin.less (2)

321-329: Change aligns with the objective; scoped and low risk.

This cleanly hides empty submenu anchors under Dokan’s admin menu without affecting other menus. Meets the PR’s intent.

324-326: Verify anchors are truly empty; whitespace or child spans will bypass :empty.

If the submenu anchors include whitespace text nodes or decorative spans, a:empty will not match. Confirm the generated markup is strictly empty for these entries; otherwise we should address the markup or broaden the selector.

Would you confirm via browser devtools that the affected submenu anchors contain no whitespace or child elements? If not, we can adjust either the PHP that outputs the menu (to emit an empty string) or add a complementary CSS approach.

jamil-mahmud · 2025-08-27T10:29:24Z

@mrabbani vai, need your kind update here

fix: hide empty Dokan Dashboard submenu in Dokan admin menu.

f73c953

Aunshon self-assigned this Aug 11, 2025

Aunshon added Needs: Testing This requires further testing Needs: Dev Review It requires a developer review and approval labels Aug 11, 2025

coderabbitai bot reviewed Aug 11, 2025

View reviewed changes

mrabbani approved these changes Sep 8, 2025

View reviewed changes

mrabbani added Dev Review Done and removed Needs: Dev Review It requires a developer review and approval labels Sep 8, 2025

mrabbani merged commit f21c947 into develop Sep 12, 2025
2 of 6 checks passed

mrabbani deleted the fix/dokan-dashboard-menu-blank-space branch September 12, 2025 13:22

coderabbitai bot mentioned this pull request Sep 23, 2025

Dashboard card, minicard and month picker component. (Base PR) #2789

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Hide empty Dokan Dashboard submenu in Dokan admin menu. #2835

Hide empty Dokan Dashboard submenu in Dokan admin menu. #2835

Uh oh!

Aunshon commented Aug 11, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Aug 11, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

jamil-mahmud commented Aug 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Hide empty Dokan Dashboard submenu in Dokan admin menu. #2835

Hide empty Dokan Dashboard submenu in Dokan admin menu. #2835

Uh oh!

Conversation

Aunshon commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

All Submissions:

Closes

How to test the changes in this Pull Request:

Changelog entry

Uh oh!

coderabbitai bot commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested labels

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

jamil-mahmud commented Aug 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Aunshon commented Aug 11, 2025 •

edited

Loading

coderabbitai bot commented Aug 11, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)