includes/Admin/Dashboard/Dashboard.php (3)

629-630: Tighten the screen detection to avoid false positives.

Using strpos( $current_screen->id, 'dokan' ) matches any screen ID containing 'dokan' as a substring, which could inadvertently match third-party plugins or custom screens (e.g., 'my-custom-dokan-page').

Apply this diff to check for a 'dokan' prefix or use a whitelist:

-        $is_dokan_screen = ( $current_screen && false !== strpos( $current_screen->id, 'dokan' ) );
+        $is_dokan_screen = ( $current_screen && 0 === strpos( $current_screen->id, 'dokan' ) );

Or use a whitelist approach for more control:

-        $is_dokan_screen = ( $current_screen && false !== strpos( $current_screen->id, 'dokan' ) );
+        $allowed_screens = [ 'toplevel_page_dokan', 'dokan_page_dokan-dashboard' ];
+        $is_dokan_screen = ( $current_screen && in_array( $current_screen->id, $allowed_screens, true ) );

---

634-634: Consider removing the unnecessary <br/> tag.

The <br/> tag after the span element may create unintended spacing in the footer. Since the React component renders inside the span, the line break might not be necessary.

Apply this diff to remove the <br/> tag:

-        $dom_element = '<span id="dokan-admin-switching" class="dokan-layout dokan-admin-page-body"></span><br/>';
+        $dom_element = '<span id="dokan-admin-switching" class="dokan-layout dokan-admin-page-body"></span>';

---

648-654: Apply the same tightened screen detection here.

This method uses the same loose strpos check as add_switching_container. For consistency and to avoid false positives, apply the same fix suggested in the previous comment.

Consider extracting the screen check into a private helper method to avoid duplication:

/**
 * Check if current screen is a Dokan admin screen.
 *
 * @since DOKAN_SINCE
 *
 * @return bool
 */
private function is_dokan_admin_screen(): bool {
    $current_screen = get_current_screen();
    return ( $current_screen && 0 === strpos( $current_screen->id, 'dokan' ) );
}

Then use it in both methods:

-        $current_screen = get_current_screen();
-		$is_dokan_screen = ( $current_screen && false !== strpos( $current_screen->id, 'dokan' ) );
-		if ( ! $is_dokan_screen ) {
+        if ( ! $this->is_dokan_admin_screen() ) {
             return $text;
         }

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro