Greptile Overview

Greptile Summary

This PR adds Brave browser detection capability to the analytics SDK by introducing an asynchronous check for the Brave browser's native API (navigator.brave.isBrave()). The core implementation resides in EventFactory's new isBraveBrowser() method, which checks for the Brave-specific navigator property and calls its async detection method. This detection is performed during context generation for every event, adding Brave identification to the analytics context object. Since Brave's detection API is inherently asynchronous, this required converting the entire event creation pipeline from synchronous to asynchronous - propagating through EventFactory.create() → EventManager.addEvent() → FormoAnalytics tracking methods. TypeScript type definitions were added to the global Navigator interface to support the Brave API. The change includes code formatting standardization (double quotes) and proper error handling for the detection logic. This fits into the SDK's broader goal of enriching analytics events with browser context information, which is particularly valuable given Brave's unique privacy features and tracking prevention mechanisms.

Confidence score: 4/5

• This PR requires careful review but appears safe to merge with moderate risk due to breaking API changes
• Score reflects the breaking change to public interfaces (sync to async), potential performance impact from detection on every event, and the need to verify all call sites properly handle the new async nature; no critical bugs detected but the architectural impact is significant
• Pay close attention to src/lib/event/type.ts (interface breaking changes), src/lib/event/EventFactory.ts (detection implementation called on every event), and verify all consumers of these APIs throughout the codebase properly await the now-async methods

Sequence Diagram

sequenceDiagram
    participant User
    participant FormoAnalytics
    participant EventFactory
    participant Navigator
    participant EventQueue

    User->>FormoAnalytics: "Initialize SDK or Trigger Event"
    FormoAnalytics->>EventFactory: "generateContext()"
    EventFactory->>Navigator: "navigator.brave?.isBrave()"
    alt Brave Browser
        Navigator-->>EventFactory: "true"
    else Not Brave
        Navigator-->>EventFactory: "false"
    end
    EventFactory->>EventFactory: "Set is_brave_browser in context"
    EventFactory-->>FormoAnalytics: "Return enriched context with is_brave_browser"
    FormoAnalytics->>EventFactory: "create(event, address, userId)"
    EventFactory->>EventFactory: "Generate event with context including is_brave_browser"
    EventFactory-->>FormoAnalytics: "Return IFormoEvent"
    FormoAnalytics->>EventQueue: "enqueue(formoEvent)"
    EventQueue-->>User: "Event tracked with Brave detection"

_{5 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

Greptile Overview

Greptile Summary

This PR adds Brave browser detection capability to the analytics SDK by introducing asynchronous browser identification. The changes convert the entire event generation pipeline from synchronous to asynchronous to accommodate Brave's promise-based navigator.brave.isBrave() API. TypeScript type definitions are added in global.d.ts to properly type the Brave API, while EventFactory implements the detection logic with a caching mechanism to avoid repeated API calls. The asynchronous nature propagates through IEventFactory and IEventManager interfaces, requiring EventManager.addEvent() and all factory methods to return Promises. Finally, FormoAnalytics.trackEvent() now properly awaits event addition. The implementation adds an is_brave_browser boolean field to all event contexts, enabling the analytics platform to track Brave browser usage alongside other browser metrics.

Confidence score: 4/5

• This PR requires careful review as it introduces a breaking API change by converting synchronous methods to asynchronous throughout the event pipeline.
• Score reflects that while the implementation is sound with proper error handling and caching, the architectural shift from sync to async affects the entire event generation flow. Points deducted for: (1) Breaking change in public interfaces requiring all consumers to update their code to await these methods, (2) Potential issues if existing code calling addEvent() doesn't properly handle the returned Promise, (3) The async nature adds overhead to every event generation call even with caching.
• Pay close attention to src/lib/event/type.ts (interface changes), src/lib/event/EventFactory.ts (core detection logic), and src/lib/event/EventManager.ts (async propagation). Verify that all callers of these methods throughout the codebase have been updated to handle Promises correctly.

Sequence Diagram

sequenceDiagram
    participant User
    participant FormoAnalytics
    participant EventFactory
    participant Navigator
    participant EventManager
    participant EventQueue

    User->>FormoAnalytics: trackEvent(type, payload)
    FormoAnalytics->>EventManager: addEvent(event, address, userId)
    EventManager->>EventFactory: create(event, address, userId)
    EventFactory->>EventFactory: generateContext(context)
    EventFactory->>Navigator: navigator.brave?.isBrave()
    alt Brave browser detected
        Navigator-->>EventFactory: true
    else Not Brave or unavailable
        Navigator-->>EventFactory: false/undefined
    end
    EventFactory->>EventFactory: Cache result in cachedIsBrave
    EventFactory->>EventFactory: Merge context with is_brave_browser flag
    EventFactory-->>EventManager: return IFormoEvent
    EventManager->>EventQueue: enqueue(formoEvent, callback)
    EventQueue-->>User: callback(err, _, data)

_{5 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

Greptile Overview

Greptile Summary

This PR adds Brave browser detection to the analytics SDK and refactors the event generation pipeline to be async. The implementation introduces a new browsers.ts module with cached browser detection using multiple heuristics (navigator.brave.isBrave(), userAgentData.brands, and user-agent string matching). All EventFactory methods were converted from synchronous to async to support the browser detection call in generateContext().

Key changes:

• New detectBrowser() function with module-level caching and in-flight request deduplication
• Browser name added to event context for all tracked events
• Type interfaces updated to return Promise types across IEventFactory and IEventManager
• Bundle size limit increased from 32KB to 36KB (12.5% increase)

Implementation strengths:

• Robust caching strategy prevents redundant API calls (browser type doesn't change during session)
• Multiple detection heuristics with proper fallbacks
• Comprehensive error handling with try-catch blocks
• In-flight promise tracking prevents race conditions on concurrent calls

Confidence Score: 4/5

• This PR is safe to merge with minimal risk; well-structured refactor with good error handling
• Score reflects solid implementation with caching, error handling, and comprehensive async refactor. The 12.5% bundle size increase is notable but acceptable for the feature value. No critical bugs identified, though the async conversion is a significant API surface change that should be monitored in production.
• No files require special attention - all changes follow consistent patterns with proper error handling

Important Files Changed

File Analysis

Sequence Diagram

sequenceDiagram
    participant App as Application
    participant FA as FormoAnalytics
    participant EM as EventManager
    participant EF as EventFactory
    participant BD as detectBrowser()
    participant Nav as Navigator API
    participant EQ as EventQueue

    App->>FA: trackEvent()
    FA->>EM: addEvent(event, address, userId)
    EM->>EF: create(event, address, userId)
    EF->>EF: generateContext()
    EF->>BD: detectBrowser()
    
    alt First call (not cached)
        BD->>Nav: navigator.brave?.isBrave()
        Nav-->>BD: Promise<boolean>
        BD->>BD: Cache result
        BD-->>EF: browserName
    else Subsequent calls (cached)
        BD-->>EF: browserName (from cache)
    end
    
    EF->>EF: Enrich context with browser
    EF-->>EM: IFormoEvent
    EM->>EQ: enqueue(formoEvent)
    EQ-->>EM: queued
    EM-->>FA: void
    FA-->>App: Promise<void>

_{3 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}